Repository navigation
Conversation
Fixes envoyproxy#1223. Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1223
With
USE_DOG_STATSD=truethe sink always built the client address asSTATSD_HOST:STATSD_PORT, so aunix://,unixgram://orunixstream://host became an invalid path such asunix:///var/run/datadog/dsd.socket:8125and stats were dropped silently.Socket addresses are now passed to the DogStatsD client unchanged and
STATSD_PORTis ignored for them. Host/port addresses are built as before. Added a unit test for the address helper and a short note in the README.Tested with
go test ./src/godogstats.