Repository navigation
Conversation
Signed-off-by: Matheus Sousa <matessousa@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
shadow_over_limiton the descriptor status when ashadow_modelimit is over its limit. Envoy added this field in envoyproxy/envoy#47903 and counts it in theratelimit.shadow_over_limitstat. Without it, Envoy can't see shadow-mode decisions, because the code is stillOK. Envoy 1.41 is the first release that reads the field; older versions ignore it.I bumped
go-control-plane/envoyto the pseudo-version of the commit that has the field, since no tag includes it yet. Go's version selection also raises grpc to 1.84.0, protobuf to 1.36.12, otel to 1.46.0 and testify to 1.12.1. Global shadow mode is out of scope: there the descriptor codes stayOVER_LIMIT, and the proto sayscodeisOKwhen the field is set.Related: envoyproxy/gateway#7785
Testing:
make compile,make check_format, and unit tests intest/limiter,test/redis,test/memcachedandtest/servicepass. I didn't run the integration tests locally because they need Redis.