Skip to content

CI: Add pre-commit linters, autoformatters - #299

Merged
ysawa0 merged 8 commits into
envoyproxy:mainfrom
ysawa0:ci-upgrade
Oct 5, 2021
Merged

ysawa0 merged 8 commits into
envoyproxy:mainfrom
ysawa0:ci-upgrade

Conversation

@ysawa0

@ysawa0 ysawa0 commented Oct 4, 2021 •

Copy link
Copy Markdown
Member
  • Add pre-commit hooks for gofumpt, goimports to autoformat go code. gofumpt is a superset of gofmt.
  • Add pre-commit hooks for prettier and some misc hooks to autoformat yaml, markdown, json, etc.
  • Run pre-commit check in CI
  • Added steps to install pre-commits / how to use it in CONTRIBUTING.md
  • There should only be styling/lint fixes, no changes to the service

ysawa0 added 7 commits October 3, 2021 19:38
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
@ysawa0
ysawa0 marked this pull request as ready for review October 5, 2021 03:15
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
@ysawa0
ysawa0 requested a review from mattklein123 October 5, 2021 03:42

@mattklein123 mattklein123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@ysawa0
ysawa0 merged commit 21fc4d3 into envoyproxy:main Oct 5, 2021
debbyku pushed a commit to debbyku/ratelimit that referenced this pull request Oct 13, 2021
* Add pre-commit linters, formatters

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* add descriptive name for fail msg step

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* shorten precommit makefile cmd

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* make fix_format

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* autoformat all lint errs

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* backtick quote to avoid formatter

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* add shfmt for bash linting

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Debby Ku <debbyku.2008@gmail.com>
debbyku pushed a commit to debbyku/ratelimit that referenced this pull request Oct 13, 2021
* Add pre-commit linters, formatters

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* add descriptive name for fail msg step

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* shorten precommit makefile cmd

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* make fix_format

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* autoformat all lint errs

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* backtick quote to avoid formatter

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* add shfmt for bash linting

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Debby Ku <debbyku.2008@gmail.com>
timcovar pushed a commit to goatapp/ratelimit that referenced this pull request Jan 16, 2024
* Add pre-commit linters, formatters

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* add descriptive name for fail msg step

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* shorten precommit makefile cmd

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* make fix_format

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* autoformat all lint errs

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* backtick quote to avoid formatter

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>

* add shfmt for bash linting

Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants