Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Webapp-only PRs currently run server and CLI tests as part of the full CI pipeline. This PR uses GitHub's native path filters to run webapp verification for those changes, while retaining full verification for other code changes and every push to
main. Publishing and deployment wait for successful post-merge verification and use the verified commit.Technical plan
Add a PR workflow filtered to
webapp/**and exclude that directory from the full verification workflow's PR trigger. Reuse the existing build and test workflows with options to skip Docker and non-webapp tests, while retaining the workspace build and static analysis. Chain publishing and deployment to successful verification of a push tomain; tag publishing keeps its existing trigger.Deviations from plan
The earlier merge-queue proposal is replaced by full verification after merge to
main, with deployment blocked on its result. Native workflow filters replace the custom path-classification script proposed in #1254.Todo
Mixed PRs touching webapp and other code trigger both workflows, with some duplicated work. Path-filtered checks, including
complete, cannot be required universally because their workflows may be skipped. Full post-merge verification can block deployment but cannot prevent a broken commit from reachingmain.Validation: workflow linting, formatting, and
git diff --checkpass locally. GitHub execution is pending this PR's checks.