Repository navigation
popover accessibility - #27
Merged
Merged
Conversation
JoeArmani
requested review from
anthonypetersen
and
a balanced review from Copilot
October 30, 2026 21:54
There was a problem hiding this comment.
🟡 Changes recommended
Two accessibility issues remain: help text has insufficient contrast in selected responses, and the live region may use the host language instead of the survey language.
2 open issues
What changed in this PR
Improves survey help popovers so screen-reader users can hear additional information while keeping focus and their place in the question.
Changes:
- Adds help descriptions, expanded-state tracking, and a dedicated live announcement region.
- Handles dismissal, canceled transitions, and stale lifecycle events.
- Expands English/Spanish automated coverage and manual screen-reader testing instructions.
| File | Description |
|---|---|
tests/setup/jsdom.js |
Models popover content and cancelable lifecycle events. |
tests/integration/eventHandlers.spec.js |
Tests descriptions, announcements, state, and cleanup. |
tests/harness/connectHost.css |
Styles inline help controls to match Connect. |
tests/fixtures/canonical/popoverHelpSpanish.txt |
Adds a Spanish help-popover fixture. |
tests/fixtures/canonical/popoverHelp.txt |
Adds an English help-popover fixture. |
tests/e2e/popoverAccessibility.spec.js |
Expands browser coverage for keyboard interaction and bilingual help. |
questionnaire.js |
Manages popover descriptions, announcements, state, and focus-related cleanup. |
i18n/es.js |
Adds the Spanish fallback help description. |
i18n/en.js |
Adds the English fallback help description. |
docs/accessibilityManualTest.md |
Adds bilingual VoiceOver and JAWS popover checks. |
common.js |
Adds a dedicated polite, atomic help announcement region. |
Review effort: Balanced
anthonypetersen
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves survey help popovers so participants using screen readers can identify and hear additional information without losing their place in the question.