You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: cover configuration comments with surrounding text - #626
No actionable comments were generated in the recent review.
Walkthrough
The integration tests add four disable-comment cases. Each case checks that the empty-block warning is suppressed and verifies the location of the suppressed message.
Adds tests for indented comments, trailing whitespace, following text, and text before and after a disable comment. Each test checks the suppressed warning location.
This PR adds test coverage for configuration comments with surrounding text and does not change runtime behavior. It is low risk to merge.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "test: cover configuration comments with surrounding text" matches the changeset. The raw summary says the PR adds ESLint plugin tests for configuration comments (disable comments) with inde…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "test: cover configuration comments with surrounding text" matches the changeset. The raw summary says the PR adds ESLint plugin tests for configuration comments (disable comments) with indentation, trailing whitespace, and surrounding text, and each test checks that the empty-block warning is suppressed. The objectives describe CSS configuration comments with text before or after them, which is a slightly different file scope than the summary's eslint test file, but the title still describes the main change. The title is concise, specific, and follows the conventional test: prefix.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Central YAML; Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: d1752f02-c257-4229-99fe-aeccf4d73d83
Commits
Reviewing files that changed from the base of the PR and between c06546f and bb90e7f.
Files selected for processing: 1
tests/plugin/eslint.test.js
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
Check all that apply.
What is the purpose of this pull request?
This adds tests that configuration comments still apply when they have text before or after them.
What changes did you make? (Give an overview)
Added following tests:
Related Issues
Verifies eslint/markdown#764 in css repo
Is there anything you'd like reviewers to focus on?
No behaviour change
Summary by CodeRabbit