Repository navigation
fix(libp2p): stop dialer hosts from overwriting rcmgr metrics - #5687
Open
gacevicljubisa wants to merge 1 commit into
Open
gacevicljubisa wants to merge 1 commit into
gacevicljubisa wants to merge 1 commit into
Conversation
sbackend123
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The autonat dialer and ping dialer hosts were created without a resource manager, so go-libp2p gave each one its default resource manager with metrics enabled. The go-libp2p stats reporter writes to package-level Prometheus collectors, so these two hosts overwrote the main host's
libp2p_rcmgr_*gauges:connections,fdsandstreamsflapped between the real value and 0 on every scrape, andlibp2p_rcmgr_limitshowed go-libp2p's autoscaled defaults instead of Bee's stream limits.The dialer hosts now get a resource manager with the same default limits but metrics disabled. The main host is unchanged. The new test asserts the
libp2p_rcmgr_limitsystem gauges carry the main host's limits.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure