Repository navigation
Conversation
akrem-chabchoub
approved these changes
Nov 5, 2026
sbackend123
approved these changes
Nov 6, 2026
Member
|
Can we remove test skip in TestClosestPeer? Follow-up: with the skip removed, One case would cover it: a peer in a bin deeper than PO(base, target), with the peers in that bin skipped. |
acud
force-pushed
the
kademlia-closest-peer
branch
from
November 10, 2026 21:13
f6ffc5b to
30c26c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes peer selection in forwarding to be stricter. This is due to some issues we've found in forwarding.
Open API Spec Version Changes (if applicable)
None
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure