fix: preserve glossary links - #45
Closed
arunimshukla wants to merge 1 commit into
Closed
arunimshukla wants to merge 1 commit into
arunimshukla wants to merge 1 commit into
Conversation
arunimshukla
requested review from
cygnusv,
oskarth and
rymnc
as code owners
September 25, 2026 19:13
rymnc
pushed a commit
that referenced
this pull request
Sep 28, 2026
Cherry-pick of [#45](#45) into this repo. ## Summary * preserve URLs on linked glossary term names in `parseGlossary` and add an optional `href` to glossary entries * render glossary definitions through `inlineMd` so links in definitions render instead of showing literal Markdown * route root map docs (`README`, `CONTRIBUTING`, `CHANGELOG`, `GLOSSARY`) to their GitHub source in `resolveHref` * regenerate `src/data/glossary.json` with the preserved hrefs; add regression tests ## Verification * applied via `git am` from the upstream patch, so original authorship (`Arunim Shukla`) is preserved on the commit * patch applied cleanly against `web-private@main` (e6de848) with no conflicts * `npm run build:graph`: 154 nodes, 74 terms; regenerated `glossary.json` is identical to the committed one * `npm test`: 58/58 passed * `npm run build`: 218 pages built Upstream author: @arunimshukla Prompted by: ac Co-authored-by: Arunim Shukla <54760103+arunimshukla@users.noreply.github.com>
Member
|
thank you @arunimshukla, merged in 63f99bd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I fixed glossary links that were being stripped during generation or rendered as literal Markdown on the glossary page.
The change:
CONTRIBUTING.mdto their GitHub sourceThis fixes cases including ERC-3643, RFC 9497, the Attestation pattern reference and the CROPS contribution reference.
Validation
I validated the change locally with:
npm run build:graphnpm testnpm run buildnpm run checkgit diff --checkResults:
astro checkcontinues to report the repository's existing diagnostics; this change does not introduce diagnostics in the modified glossary files.