fix(whatsmeow): reuse pooled authDB connection in StartClient (fixes #175)

[wilsonborba]

Problem

StartClient calls sqlstore.New(ctx, "postgres", config.PostgresAuthDB, ...) on every invocation, opening a brand new *sql.DB connection pool each time. container.Close() is never called, so the old pool (and every connection it opened) is simply dropped.

StartClient is re-entered on:

• ReconnectClient, which calls StartInstance -> StartClient again
• the kill-channel branch of StartClient's own select loop, which unconditionally restarts on any kill signal
• every QR pairing attempt that ends in a restart

Each path leaks one unbounded connection pool. Reproduced locally against a real Postgres instance: 15 consecutive POST /instance/reconnect calls grew evogo_auth connections from a baseline of 2 to 32, exceeding the app's own SetMaxOpenConns(25) cap, which confirms the leaked connections come from a pool outside the one the app manages. In production this exhausts max_connections under normal instance create/reconnect activity, surfacing as pq: sorry, too many clients already and QR pairing timeouts.

Closes #175.

Fix

Reuse the already-pooled, bounded authDB *sql.DB (whatsmeowService already holds it as a field, configured once in config.CreateAuthDB with SetMaxOpenConns/SetMaxIdleConns/SetConnMaxLifetime/SetConnMaxIdleTime) via sqlstore.NewWithDB(w.authDB, "postgres", dbLog) instead of opening a new pool per call, then run container.Upgrade(ctx) explicitly since NewWithDB does not auto-upgrade like sqlstore.New does.

Falls back to the previous sqlstore.New behavior if authDB is unexpectedly nil (it should always be set when PostgresAuthDB is configured, see main.go), so this can't introduce a nil-pointer panic.

No changes to the SQLite fallback path.

Verification

Tested against a real Postgres 192.168.x LAN instance with an actual WhatsApp session paired via QR:

	Before fix	After fix
Baseline connections	2	2
After 15x /instance/reconnect	32 (exceeds pool cap of 25)	2
Session state after cycling	Connected: true, LoggedIn: true	Connected: true, LoggedIn: true

go build ./... passes on top of develop with the whatsmeow-lib submodule initialized.

Notes

This is the same root cause already reported/attempted in #102, #117, #131, #168 and #174. This PR takes the smaller-diff approach from #168/#174 (reuse w.authDB via NewWithDB rather than introducing a new package-level singleton container), and additionally guards against a nil authDB per the review feedback left on #174.

Summary by Sourcery

Prevent WhatsApp client restarts from leaking PostgreSQL connection pools by reusing the configured authentication database connection.

Bug Fixes:

• Reuse the existing bounded PostgreSQL authentication database pool across WhatsApp client restarts to prevent connection-pool leaks and database connection exhaustion.
• Preserve a safe fallback to per-call PostgreSQL initialization when the shared authentication database is unexpectedly unavailable.

Enhancements:

• Explicitly upgrade reused WhatsApp database containers while retaining the existing SQLite fallback path.

[sourcery-ai]

Sorry @wilsonborba, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[sourcery-ai]

Reviewer's Guide

This PR changes how the WhatsMeow service initializes its SQL container in StartClient so that it reuses the existing pooled Postgres authDB connection when available, ensuring upgrades are run explicitly and keeping logging behavior consistent across Postgres and SQLite paths while preserving a safe fallback to the previous behavior.

File-Level Changes

Change	Details	Files
Reuse the existing pooled Postgres authDB connection in StartClient instead of creating a new connection pool on each call, with an explicit container upgrade.	Introduce a shared dbLog variable so it can be reused for both Postgres and SQLite container initialization. When PostgresAuthDB is configured and authDB is non-nil, call sqlstore.NewWithDB with w.authDB, the postgres driver, and dbLog. After creating the container via NewWithDB, explicitly call container.Upgrade with a background context and log and return early on error. If PostgresAuthDB is configured but authDB is nil, fall back to the previous sqlstore.New-based behavior instead of panicking. Keep the SQLite path but switch it to use dbLog when WaDebug is enabled instead of passing nil, and remove the duplicated branching that mixed debug and backend selection.	pkg/whatsmeow/service/whatsmeow.go

Possibly linked issues

• Postgres connection pool leak on every StartClient/reconnect cycle #175: PR reuses w.authDB via sqlstore.NewWithDB in StartClient, fixing the Postgres connection pool leak described.
• Postgres connection pool leak on every StartClient/reconnect cycle #175: PR reuses the existing pooled authDB via sqlstore.NewWithDB in StartClient, preventing the reported Postgres pool leak.
• Postgres connection pool leak on every StartClient/reconnect cycle #175: PR reuses shared authDB via NewWithDB in StartClient, preventing new pools on reconnect and fixing the leak.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[pastoriniMatheus]

Thanks — and as with #174, this is credit rather than a plain "duplicate".

sqlstore.NewWithDB(w.authDB, "postgres", dbLog) is the correct shape: it reuses the pool that cmd/evolution-go/main.go already opens and caps, instead of opening a second one against the same DSN. That exact change is being requested on #117 so the fix does not end up with two pools and a third set of pool numbers.

We are converging on #117 rather than this one because it ships a regression test and calls Upgrade() once instead of on every StartClient — but the postgres path there is going to look like yours.