Repository navigation
[P3] Small cleanups in metrics.go, evnode and evm clients #51
Description
Priority: P3 (refactor) · Effort: S
Small cleanups:
pkg/metrics/metrics.go: keylastSubmissionDurationsbystruct{chainID, typ string}instead of"a:b"plusstrings.Split. Moot if option A of the submission-duration issue is chosen.RecordSubmissionDaHeight: collapse the duplicated header and data branches into amap[string]uint64.internal/clients/evnode/client.go: delete the unusedGetStateandGetGenesisDaHeight.internal/clients/evm/client.go:76: the JSON-RPC duration is measured beforeio.ReadAll, which contradicts the comment at line 78. Movetime.Since(startTime)after the read, and also check for a JSON-RPCerrorfield in the response body.RecordSubmissionAttemptruns once per block on its final outcome, not once per RPC attempt. Rename or clarify it in the README.
Activity
auricom commentedon Oct 20, 2026
Status after #58: the verifier no longer calls
evnode.GetBlockdirectly (onlyGetBlockWithBlobs, which uses it internally).GetStateandGetGenesisDaHeightare still unused. The other items are unchanged.auricom commentedon Oct 20, 2026
Status after #57–#59:
lastSubmissionDurations"a:b"key andstrings.Splitwere removed in P2: self-observability, /health, receive delay, tx-block header checks, URL reda #59, together withRefreshSubmissionDuration([P2] Decide: RefreshSubmissionDuration fabricates summary samples #48). Skip that item.RecordSubmissionDaHeight(still two copies, withlatestHeaderDaHeight/latestDataDaHeightfields), delete the unusedevnode.GetStateandGetGenesisDaHeight, and fix the JSON-RPC RTT inevm/client.go(measured beforeio.ReadAll; theerrorfield in the response body is still not checked).RecordSubmissionAttemptis called once per block on its final outcome, not per RPC attempt. Now that tx blocks verify header and data separately ([P2] Verify header blob for blocks with transactions too #47), it is called once per blob type, so describe it as "once per blob type per verification round" in the README.refactor: small cleanups in metrics, evnode and evm clients
Merge subagent: P3 #50 #51 metrics and client cleanups