Skip to content

[P1] Bump vulnerable deps: go-ethereum ≥1.17.0, grpc ≥1.83.1, x/net ≥0.60.0 (supersedes #30) #54

Closed

Description

@auricom

Priority: P1 (security) · Effort: S · Supersedes: #30

govulncheck ./... on the branch of #33 (ev-node v1.0.0 upgrade) reports 11 vulnerabilities in code paths it reaches:

Module Current Fixed in IDs
github.com/ethereum/go-ethereum v1.16.5 v1.17.0 GO-2026-4508 (1.17.0); GO-2026-4314, GO-2026-4315 (1.16.8)
google.golang.org/grpc v1.79.2 v1.83.1 GO-2026-6348, GO-2026-6061 (also GO-2026-4762, flagged by CodeRabbit on #33)
golang.org/x/net v0.51.0 v0.60.0 GO-2026-6603, -6611, -6612, -6617
github.com/cometbft/cometbft (indirect) v0.38.19 v0.38.21 GO-2026-4361
golang.org/x/crypto v0.48.0 no fix yet GO-2026-5932

#30 is not enough: it only reaches go-ethereum 1.16.8, which leaves GO-2026-4508 open.

Proposed fix

  1. Merge fix(deps): upgrade ev-node to v1.0.0 and fix broken metrics #33 first. It rewrites go.mod and would conflict with chore(deps): bump github.com/ethereum/go-ethereum from 1.16.5 to 1.16.8 in the go_modules group across 1 directory #30.
  2. Run go get github.com/ethereum/go-ethereum@v1.17.0 google.golang.org/grpc@v1.83.1 golang.org/x/net@v0.60.0 github.com/cometbft/cometbft@v0.38.21 && go mod tidy.
  3. Close chore(deps): bump github.com/ethereum/go-ethereum from 1.16.5 to 1.16.8 in the go_modules group across 1 directory #30.
  4. Add a govulncheck step to CI (tracked in [P3] Dockerfile: static non-root build; CI: run tests with -race #52).

Notes

ev-metrics is only a client of gRPC and EVM nodes, and it doesn't use go-ethereum's p2p stack, so several of these are low-impact in practice. The bump is still cheap and keeps scanners green.

Acceptance criteria

  • govulncheck ./... reports only issues with no available fix.
  • make test and make lint pass.

Activity

  1. added
    bugSomething isn't working
    dependenciesPull requests that update a dependency file
    on Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdependenciesPull requests that update a dependency file

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions