Repository navigation
🔧 changesets: downgrade non-collateral to patch - #820
Conversation
|
| Name | Type |
|---|---|
| @exactly/protocol | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d1ca2a6b7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,5 @@ | |||
| --- | |||
| "@exactly/protocol": minor | |||
| "@exactly/protocol": patch | |||
There was a problem hiding this comment.
The described feature changes the external Auditor.enableMarket ABI by adding the bool nonCollateral argument (without retaining the prior overload), so governance or deployment integrations compiled against 0.2.24 will send the old selector and fail after an Auditor upgrade. Publishing this as a patch produces 0.2.25 through the release workflow and incorrectly advertises that such consumers can update without adapting; retain at least the minor bump so the incompatible API change is signaled.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
========================================
Coverage 94.79% 94.79%
========================================
Files 31 31
Lines 2745 2745
Branches 368 472 +104
========================================
Hits 2602 2602
Misses 142 142
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
2 participants
Summary by CodeRabbit
@exactly/protocolrelease classification from minor to patch.