🔧 Remove optional dependency on the unmaintained commonmark package - #427
Merged
Conversation
This library was deprecated in 2022.
The `commonmark` package is no longer an optional dependency, so drop the benchmark that imports it (it would fail `tox -e py311-bench-packages`) and its row in the performance table, and note the change in the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #401 by @nikolas, whose fork does not allow maintainer pushes; their commit is carried here verbatim with authorship preserved (thank you!).
The
commonmarkPyPI package was deprecated in 2022 (last release 2019). #401 dropped it from thecompareextra but leftbenchmarking/bench_packages.py::test_commonmark_pyimporting it unguarded, sotox -e py311-bench-packages(which installsbenchmarking,compare) would have errored. This PR removes that benchmark too.The
commonmark-pyrow indocs/performance.mdis kept, with a footnote explaining that the package is deprecated, has been removed from the benchmark suite, and that the figures are from the last run that included it. The historical comparison is still informative.A changelog line with the rationale is added.
Commits
Remove optional dependency on commonmark— the contributor's commit, unchanged.🔧 MAINTAIN: Remove remaining commonmark references— drops the orphaned benchmark, adds the changelog line.📚 DOCS: Keep the commonmark-py benchmark row, with a deprecation footnote, plus a changelog wording tweak.Verification
commonmarkmentions inpyproject.toml,tox.iniandbenchmarking/refer to the CommonMark spec or thecommonmarkpreset, none to the package.