feat: add source bucket DID to authorize response - #72
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
Add non-empty SourceBucket coverage to the round-trip test.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds an optional source bucket DID to AuthorizeOK responses for copy requests.
Changes:
- Adds
SourceBuckettoAuthorizeOK. - Updates DAG-JSON and CBOR serialization.
File summaries
| File | Summary |
|---|---|
commands/s3/request/types.go |
Defines the optional source bucket DID. Nit: add a distinct source DID to TestAuthorizeOKRoundTrip. |
commands/s3/request/json_gen.go |
Adds DAG-JSON encoding and decoding support. |
commands/s3/request/cbor_gen.go |
Adds CBOR encoding and decoding support. |
Review details
Files not reviewed (2)
- commands/s3/request/cbor_gen.go: Generated file
- commands/s3/request/json_gen.go: Generated file
- Files reviewed: 1/3 changed files
- Comments generated: 1
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the authorized request is for a copy, include the source bucket (space) DID in the repsonse.