refactor: flat metric samples - #77
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煝 Approval recommended
All reviewed changes are covered with no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Refactors metric samples into a flat slice and updates generated serialization codecs and tests.
Changes:
- Replaces provider-keyed samples with
[]SampleItem. - Regenerates CBOR and DAG-JSON codecs.
- Removes obsolete custom codecs and updates round-trip tests.
| File | Description |
|---|---|
commands/鈥媘etrics/鈥媡ypes.go |
Defines the flat samples API. |
commands/鈥媘etrics/鈥媕son_gen.maps.go |
Updates DAG-JSON serialization. |
commands/鈥媘etrics/鈥媑en/鈥媘ain.go |
Removes obsolete generator guidance. |
commands/鈥媘etrics/鈥媍odec.go |
Removes obsolete custom codecs. |
commands/鈥媘etrics/鈥媍odec_test.go |
Updates codec round-trip coverage. |
commands/鈥媘etrics/鈥媍bor_gen.maps.go |
Updates CBOR serialization. |
Files not reviewed (2)
- commands/metrics/cbor_gen.maps.go: Generated file
- commands/metrics/json_gen.maps.go: Generated file
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For simplicity we decided not to expose the provider here. This code was not used in production yet so is fine to change.