You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
INTER-779: Document commit conventions and release process in contributing.md - #294
Expands contributing.md so contributors know how to write commit messages and how releases are made. This only changes the contributing.md file.
Commit messages: links to Conventional Commits and the commitlint config that the Analyze Commit Messages check uses.
Git hooks: What the husky hooks do (commit-msg, pre-commit, pre-push).
How to publish: how to add a changeset, how to pick patch/minor/major based on the type of change and what that does to the version, and what happens after merge (Release [changeset] PR, tag, publish to npm).
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Explain commit types, scopes and breaking change syntax with examples, document the Git
hooks, and describe how changesets decide versions and drive releases.
Related-Task: INTER-779
Update example references the wrong OpenAPI generator
contributing.md:61
This update example names openapi-generator, but this SDK's generation script imports openapi-typescript and package.json declares only openapi-typescript. Using the absent tool as a repository-specific example may send contributors toward the wrong dependency; use the generator actually used by this project.
Release workflow skips PRs when merged changes lack changesets
contributing.md:200
The release workflow does not open or update a release PR after every merged PR: the reusable workflow first checks for pending changesets and only takes the PR path when they exist. As written, this incorrectly promises a release PR even after docs/internal PRs that correctly omit a changeset.
Soften the pre-push hook description, use openapi-typescript in the build example, and
clarify that only PRs with changesets open the release PR.
Related-Task: INTER-779
Replace the commit format details with links to Conventional Commits and the commitlint
config, since they are not SDK-specific.
Related-Task: INTER-779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands
contributing.mdso contributors know how to write commit messages and how releases are made. This only changes thecontributing.mdfile.Analyze Commit Messagescheck uses.commit-msg,pre-commit,pre-push).Release [changeset]PR, tag, publish to npm).