Skip to content

INTER-779: Document commit conventions and release process in contributing.md - #294

Merged
erayaydin merged 5 commits into
mainfrom
docs/contributing-release-process-inter-779
Oct 12, 2026
Merged

erayaydin merged 5 commits into
mainfrom
docs/contributing-release-process-inter-779

Conversation

@erayaydin

@erayaydin erayaydin commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Expands contributing.md so contributors know how to write commit messages and how releases are made. This only changes the contributing.md file.

  • Commit messages: links to Conventional Commits and the commitlint config that the Analyze Commit Messages check uses.
  • Git hooks: What the husky hooks do (commit-msg, pre-commit, pre-push).
  • How to publish: how to add a changeset, how to pick patch/minor/major based on the type of change and what that does to the version, and what happens after merge (Release [changeset] PR, tag, publish to npm).

@changeset-bot

changeset-bot Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5a03d0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 98.25% 168/171
🟢 Branches 97.03% 98/101
🟢 Functions 100% 37/37
🟢 Lines 98.21% 165/168

Test suite run success

132 tests passing in 30 suites.

Report generated by 🧪jest coverage report action from 5a03d0f

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 98.24 97.02 100 98.21
🟢  src 98.54 98.76 100 98.51
🔴   ...edApiTypes.ts 0 0 0 0
🔴   index.ts 0 0 0 0
🟢   sealedResults.ts 100 100 100 100
🟢   ...rApiClient.ts 96.15 97.22 100 96.15 360,364
🟢   types.ts 100 100 100 100
🟢   urlUtils.ts 100 100 100 100
🟢   webhook.ts 100 100 100 100
🟢  src/errors 97.05 90 100 96.96
🟢   apiErrors.ts 100 100 100 100
🟢   ...orResponse.ts 100 100 100 100
🟢   toError.ts 87.5 88.88 100 87.5 21
🟢   unsealError.ts 100 50 100 100 14

Explain commit types, scopes and breaking change syntax with examples, document the Git
hooks, and describe how changesets decide versions and drive releases.

Related-Task: INTER-779
@erayaydin
erayaydin force-pushed the docs/contributing-release-process-inter-779 branch from 58623db to 4365237 Compare October 7, 2026 15:28
@erayaydin
erayaydin requested a balanced review from Copilot October 7, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

2 open findings
What changed in this PR

Updates contributor documentation to clarify commit message conventions and the changeset-based release process.

Changes:

  • Document Conventional Commits usage (types, scopes, breaking changes) and local Git hooks.
  • Expand changesets guidance with examples, bump mapping, and release flow steps.
File Description
contributing.md Adds detailed commit message and changeset/release process guidance for contributors.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread contributing.md Outdated
Comment thread contributing.md
Narrow the changeset criterion to public API or behavior changes and make the breaking
change row cover any <type>! commit.

Related-Task: INTER-779

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Two documentation details inaccurately describe the project’s generator and release workflow.

0 open findings

2 resolved since last review
Previously missed (2)

In code that hasn't changed since last review

Low severity Update example references the wrong OpenAPI generator

contributing.md:61

This update example names openapi-generator, but this SDK's generation script imports openapi-typescript and package.json declares only openapi-typescript. Using the absent tool as a repository-specific example may send contributors toward the wrong dependency; use the generator actually used by this project.

Low severity Release workflow skips PRs when merged changes lack changesets

contributing.md:200

The release workflow does not open or update a release PR after every merged PR: the reusable workflow first checks for pending changesets and only takes the PR path when they exist. As written, this incorrectly promises a release PR even after docs/internal PRs that correctly omit a changeset.

🧠 Review effort: Balanced

Soften the pre-push hook description, use openapi-typescript in the build example, and
clarify that only PRs with changesets open the release PR.

Related-Task: INTER-779
@erayaydin
erayaydin marked this pull request as ready for review October 7, 2026 16:48
JuroUhlar
JuroUhlar previously approved these changes Oct 7, 2026
Replace the commit format details with links to Conventional Commits and the commitlint
config, since they are not SDK-specific.

Related-Task: INTER-779
Make Git hooks a sibling of the Commit messages heading, since the hooks cover more than
commit messages.

Related-Task: INTER-779
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@erayaydin
erayaydin requested a review from JuroUhlar October 8, 2026 08:50
@erayaydin
erayaydin merged commit 1505112 into main Oct 12, 2026
19 checks passed
@erayaydin
erayaydin deleted the docs/contributing-release-process-inter-779 branch October 12, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants