Conversation
MSVC warns C4238 when these Auth calls take the address of the temporary returned by getProviderFromArguments. Flutter builds Windows plugins with /WX, so that warning fails the build on newer MSVC toolsets.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
SignInWithProvider,LinkWithProvider, andReauthenticateWithProviderpassed&getProviderFromArguments(...), which takes the address of a temporaryFederatedOAuthProvider. That is an MSVC extension (warning C4238). Flutter compiles Windows plugins with/W4 /WX, so the warning fails the build on newer MSVC toolsets.Each call now stores the provider in a named local and passes that pointer. On desktop the C++ SDK only null-checks the pointer inside the call, so the local covers the use.
Our Windows CI already builds this file with Visual Studio 2026 18.9 / MSVC 14.51 and does not emit C4238. The report is from a development toolset, so that CI run will not show the warning disappearing.
Related Issues
Fixes #18698
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?