Skip to content

fix(auth,windows): avoid taking the address of a temporary provider - #18702

Draft
SelaseKay wants to merge 1 commit into
mainfrom
auth_18698
Draft

SelaseKay wants to merge 1 commit into
mainfrom
auth_18698

Conversation

@SelaseKay

Copy link
Copy Markdown
Contributor

Description

SignInWithProvider, LinkWithProvider, and ReauthenticateWithProvider passed &getProviderFromArguments(...), which takes the address of a temporary FederatedOAuthProvider. That is an MSVC extension (warning C4238). Flutter compiles Windows plugins with /W4 /WX, so the warning fails the build on newer MSVC toolsets.

Each call now stores the provider in a named local and passes that pointer. On desktop the C++ SDK only null-checks the pointer inside the call, so the local covers the use.

Our Windows CI already builds this file with Visual Studio 2026 18.9 / MSVC 14.51 and does not emit C4238. The report is from a development toolset, so that CI run will not show the warning disappearing.

Related Issues

Fixes #18698

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

MSVC warns C4238 when these Auth calls take the address of the temporary
returned by getProviderFromArguments. Flutter builds Windows plugins with
/WX, so that warning fails the build on newer MSVC toolsets.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MSVC] Flutterfire failed due to warning C4238 on Windows with VS2026

1 participant