Repository navigation
fix(auth,web): fail onWaitInitState instead of hanging when the first auth state is an error #18705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lyokone
merged 2 commits into
firebase:main
from
chiliec:fix/auth-web-wait-init-state-error
Sep 28, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
packages/firebase_auth/firebase_auth_web/test/on_wait_init_state_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // Copyright 2026 The Chromium Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| @TestOn('browser') | ||
| library; | ||
|
|
||
| import 'dart:js_interop'; | ||
| import 'dart:js_interop_unsafe'; | ||
|
|
||
| import 'package:firebase_auth_web/src/interop/auth.dart' as auth_interop; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| /// Minimal stand-in for the JS `Auth` object: `onAuthStateChanged` invokes | ||
| /// either the next or the error callback once, and records unsubscribe. | ||
| ({auth_interop.Auth auth, bool Function() unsubscribed}) fakeAuth({ | ||
| JSObject? error, | ||
| }) { | ||
| var unsubscribed = false; | ||
| final jsAuth = JSObject(); | ||
| jsAuth['onAuthStateChanged'] = (JSFunction next, JSFunction? onError) { | ||
| if (error != null) { | ||
| onError!.callAsFunction(null, error); | ||
| } else { | ||
| // ignore: avoid_redundant_argument_values | ||
| next.callAsFunction(null, null); | ||
| } | ||
| return (() { | ||
| unsubscribed = true; | ||
| }).toJS; | ||
| }.toJS; | ||
| return ( | ||
| auth: auth_interop.Auth.getInstance(jsAuth as auth_interop.AuthJsImpl), | ||
| unsubscribed: () => unsubscribed, | ||
| ); | ||
| } | ||
|
|
||
| test('onWaitInitState completes when the first auth state arrives', () async { | ||
| final fake = fakeAuth(); | ||
|
|
||
| await fake.auth.onWaitInitState(); | ||
|
|
||
| expect(fake.unsubscribed(), isTrue); | ||
| }); | ||
|
|
||
| test( | ||
| 'onWaitInitState fails instead of hanging when the first auth state is an error', | ||
| () async { | ||
| final error = JSObject(); | ||
| error['code'] = 'auth/internal-error'.toJS; | ||
| final fake = fakeAuth(error: error); | ||
|
|
||
| await expectLater( | ||
| fake.auth.onWaitInitState().timeout(const Duration(seconds: 2)), | ||
| throwsA( | ||
| predicate<Object>( | ||
| (e) => (e as JSObject)['code'].dartify() == 'auth/internal-error', | ||
| ), | ||
| ), | ||
| ); | ||
| expect(fake.unsubscribed(), isTrue); | ||
| }, | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change in the error callback: complete the wait before
addError.addErroris synchronous. If it throws,completeErrornever runs and awaitcompleter.futurewaits forever again. During plugin registration the controller is still null, so?.addErrordoes not throw today. Completing first keeps the wait settled if that changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thanks. Done in 37e61e0: the wait now completes with the error before
addErrorruns, so a throwingaddErrorcan't leavecompleter.futurepending.