Repository navigation
ci(NoTicket): use GitHub App token for releases - #535
Merged
Merged
Conversation
|
Contributor
Author
|
integration test trial run: https://github.com/firebolt-db/firebolt-python-sdk/actions/runs/37604834916 -- looking good |
pscls
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Release publishing currently fails at checkout because
RELEASE_PATno longer authenticates. Mint a short-lived, repository-scoped installation token using the org-wide FB_DB_CI_WRITER app and use it for checkout and the release action's version commit and tag pushes.Use the same app secrets as the Go SDK:
GH_APP_FB_DB_CI_WRITER_CLIENT_IDandGH_APP_FB_DB_CI_WRITER_APP_KEY_PEM, with only contents write permission requested. Pass the two staging credentials explicitly through the integration workflows instead of inheriting all secrets.Checkout credentials remain persisted because the shared
action-python-releaserunsgit push origininternally. GitHub release creation retains the job's existingGITHUB_TOKENcontents write permission.References: Kafka migration, Go SDK app setup, failed release.
Validation: workflow YAML, reusable workflow secret declarations, job dependencies, and applicable pre-commit checks pass. No release was triggered.
Before running a release, verify the org-wide app is installed on this repo and both org secrets are available to it. My account cannot inspect organization secret access policies.
Note
Medium Risk
Release publishing depends on new org app secrets and token minting; misconfiguration could block releases or affect git push during publish.
Overview
Fixes release workflow authentication by replacing the broken
RELEASE_PATcheckout with a short-lived token from the org FB_DB_CI_WRITER GitHub App (actions/create-github-app-token, contents write only). Checkout now uses that token and setspersist-credentials: trueso the sharedaction-python-releasestep can still push the version commit and tag.Integration test wiring no longer uses
secrets: inheriton reusable workflow calls inintegration-tests.ymlandrelease.yml; only the two staging Firebolt identity secrets are passed through explicitly tointegration-tests-v2.Reviewed by Cursor Bugbot for commit 64024cb. Bugbot is set up for automated code reviews on this repo. Configure here.