Repository navigation
fix(NoTicket): remove password hashes from token cache filenames - #540
Merged
Merged
Conversation
Use identity-based, versioned cache filenames and discard legacy cache files, including those left after credential rotation. Do not migrate old tokens. Cover cache isolation, cleanup, and wrong-password handling. Isolate real-filesystem unit test fixtures from the user token cache.
gm42
approved these changes
Oct 7, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Use identity-based, versioned cache filenames and discard legacy cache files, including those left after credential rotation. Do not migrate old tokens.
Cover cache isolation, cleanup, and wrong-password handling. Isolate real-filesystem unit test fixtures from the user token cache.
Note
Medium Risk
Changes on-disk token cache layout and deletes legacy cache files on startup, forcing re-auth for affected users; encryption still depends on password for read access.
Overview
Token cache files are renamed so filenames no longer embed a password hash—only a username-derived
token-v2-{hash}.jsonpath is used. OnTokenSecureStorageinit, legacy64-hex-char.jsoncache files are deleted (no token migration), so users with old caches must sign in again.A password change for the same username now hits the same cache file but cannot decrypt the stored token (expected). Tests cover filename stability, legacy cleanup, and that unrelated files/dirs in the cache folder are left alone. Unit tests that use the real filesystem get an autouse fixture that redirects
user_data_dirtotmp_path.Reviewed by Cursor Bugbot for commit 19984f8. Bugbot is set up for automated code reviews on this repo. Configure here.