Skip to content

ci(NoTicket): update Node 24 actions and clean up Core credentials #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorenzhs merged 3 commits into from
Oct 7, 2026
Merged

ci(NoTicket): update Node 24 actions and clean up Core credentials #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31b4e71
ci: replace deprecated commit status action
lorenzhs Oct 7, 2026
7edf2b3
ci: adopt Node 24 integration setup actions
lorenzhs Oct 7, 2026
900d24e
ci: remove unused Core staging secret references
lorenzhs Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/integration-tests-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:

- name: Setup Firebolt Core
id: setup-core
uses: firebolt-db/action-setup-core@eabcd701de0be41793fda0655d29d46c70c847c2 # main
uses: firebolt-db/action-setup-core@c1a5dc8d2f54509084037487c6ff71643f695790 # main
with:
tag_version: ${{ inputs.tag_version || vars.DEFAULT_CORE_IMAGE_TAG }}

Expand All @@ -74,8 +74,8 @@ jobs:

- name: Run integration tests HTTP
env:
SERVICE_ID: ${{ secrets.FIREBOLT_CLIENT_ID_STG_NEW_IDN }}
SERVICE_SECRET: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }}
SERVICE_ID: ""
SERVICE_SECRET: ""
DATABASE_NAME: "firebolt"
ENGINE_NAME: ""
STOPPED_ENGINE_NAME: ""
Expand All @@ -87,8 +87,8 @@ jobs:

- name: Run integration tests HTTPS
env:
SERVICE_ID: ${{ secrets.FIREBOLT_CLIENT_ID_STG_NEW_IDN }}
SERVICE_SECRET: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }}
SERVICE_ID: ""
SERVICE_SECRET: ""
DATABASE_NAME: "firebolt"
ENGINE_NAME: ""
STOPPED_ENGINE_NAME: ""
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

- name: Setup database and engine
id: setup
uses: firebolt-db/integration-testing-setup@813c4835ef38adcba3f8760e7afc21a3c7248023 # v2.6.2
uses: firebolt-db/integration-testing-setup@39ed7c82e431c3a073ca8f14b8341c631e72ef4a # new-identity
with:
firebolt-client-id: ${{ secrets.FIREBOLT_CLIENT_ID_STG_NEW_IDN }}
firebolt-client-secret: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }}
Expand Down
21 changes: 14 additions & 7 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Decorate commit
uses: Sibz/github-status-action@650dd1a882a76dbbbc4576fb5974b8d22f29847f # v1.1.6
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
env:
NEEDS_RESULTS: ${{ toJSON(needs) }}
with:
authToken: ${{secrets.GITHUB_TOKEN}}
context: 'Integration tests'
description: "${{ contains(needs.*.result, 'failure') && 'Failed' || 'Successful' }}"
state: "${{ contains(needs.*.result, 'failure') && 'failure' || 'success' }}"
sha: ${{github.event.pull_request.head.sha || github.sha}}
target_url: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
script: |
const failed = Object.values(JSON.parse(process.env.NEEDS_RESULTS))
.some(job => job.result === 'failure');
await github.rest.repos.createCommitStatus({
...context.repo,
sha: context.payload.pull_request?.head.sha || context.sha,
context: 'Integration tests',
description: failed ? 'Failed' : 'Successful',
state: failed ? 'failure' : 'success',
target_url: `${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`,
});
2 changes: 1 addition & 1 deletion .github/workflows/nightly-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:

- name: Setup database and engine
id: setup
uses: firebolt-db/integration-testing-setup@813c4835ef38adcba3f8760e7afc21a3c7248023 # v2.6.2
uses: firebolt-db/integration-testing-setup@39ed7c82e431c3a073ca8f14b8341c631e72ef4a # new-identity
with:
firebolt-client-id: ${{ secrets.FIREBOLT_CLIENT_ID_STG_NEW_IDN }}
firebolt-client-secret: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }}
Expand Down
Loading