Repository navigation
fix(fork): merge upstream 15702a9 into patch/bots - #96
Merged
Merged
Conversation
…ngdotgg#24738) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ingdotgg#24742) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…he list (pingdotgg#24749) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pingdotgg#24760) With the Working shelf on, a thread that stops working stays there for 2s. A server auto-settle in that window sends it straight to Settled, so threads no longer flash in the inbox and vanish. "Thread completed" waits the same 2s and fires once. The server now settles fast enough to land inside the window: it reads a pull request when a shell merge or close command ends, sweeps a thread when its background work ends, and runs per-thread settle checks in parallel, one per thread at a time. Takes over pingdotgg#22458. Co-authored-by: Omar <76748259+omar9848492@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#24650) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pingdotgg#24710) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gdotgg#24766) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…mbers drafts (pingdotgg#24750) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tgg#24770) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Upstream pingdotgg#24760 stops threads flashing in the inbox before they settle: shelf placement now reads a working observer, and completion notifications fire from a timer. - threadInbox.ts and its test: keep upstream's diagnostics comment and imports, plus this patch's bot imports. - threadListV2.ts, useThreadListV2.ts: keep upstream's isWorking input next to botShelfExpanded, and the Bots shelf branch before the working check. - Sidebar.tsx: bot threads go to the Bots shelf before upstream's observed-working check. - ThreadNotificationCoordinator.tsx: take upstream's timer-based flow and move the bot skip into present(), where notifications are now shown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork's nightly build fails because this patch conflicts with upstream commit 15702a9.
Upstream's pingdotgg#24760 stops threads from flashing in the inbox before they settle. Shelf placement now reads a working observer, and completion notifications now fire from a timer.
packages/client-runtime/src/state/threadInbox.tsand its test: kept upstream's diagnostics comment and test imports, plus this patch's bot imports.apps/mobile/src/features/threads/threadListV2.tsanduseThreadListV2.ts: kept upstream's newisWorkinginput next tobotShelfExpanded. Bot threads still go to the Bots shelf before the working check.apps/web/src/components/Sidebar.tsx: bot threads go to the Bots shelf before upstream's working check, which now uses the observer.apps/web/src/components/ThreadNotificationCoordinator.tsx: took upstream's timer-based flow. This patch's rule that bot threads only notify while they need the user moved intopresent(), where upstream now shows notifications. The rule checks the thread at the moment the notification would show.Verification:
vp run typecheckinapps/web,apps/mobileandpackages/client-runtime: 0 errors.vp test run:threadInbox.test.ts25 passed, mobilethreadListV2.test.ts65 passed, webSidebar.logic.test.ts60 passed.vp linton the resolved files: no errors.patch/release, this branch,patch/cache-expiry-compaction,patch/mobile-launch-crashandpatch/mobile-fork-identitymerge with no conflicts. The repo-widevp run typecheckthe build runs passes all 34 tasks.Made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code