Bump tdx-attest dependency to latest version - #98
Merged
Merged
Conversation
alexhulbert
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates phala's
tdx-attestcrate to the latest version.The new version introduces a timeout for quote generation which we would benefit from - meaning processes stuck during quote generation wont hang. But worth noting the mutex lock has no timeout so hanging is still technically possible.
The crate comes from the dstack monorepo, not crates.io. Its worth noting that this repo has some significant changes and now uses git submodules to include a whole load of yocto stuff. These get pulled by cargo when adding this crate, which does mean slower builds with this update. It would be nice if phala would publish this crate. I could nag them about it, but it doesnt help that there is already a crate with the same name on crates.io.
The new version has no API changes - this PR only updates the dependency version.