fix: remove max_gas_per_txn check in syncer path - #579
Merged
Merged
Conversation
akundaz
requested review from
0x416e746f6e,
SozinM and
avalonche
as code owners
September 23, 2026 13:17
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Add a syncer-path regression test covering over-limit deposits and non-deposit transactions.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates flashblock syncer execution so L1 deposits bypass max_gas_per_txn, while regular transactions remain limited.
Changes:
- Exempts deposits from the per-transaction gas check in the syncer path.
| File | Description |
|---|---|
crates/op-rbuilder/src/builder/payload_handler.rs |
Applies the deposit gas-limit exemption during syncer execution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sebastianst
reviewed
Sep 23, 2026
Comment on lines
374
to
381
Contributor
There was a problem hiding this comment.
Suggested change
I'd just remove this entire check, the flag is a builder flag only. The verifier path shouldn't enforce a gas per tx limit if the tx is otherwise valid.
Contributor
Author
There was a problem hiding this comment.
Fair enough, removed the check
akundaz
force-pushed
the
ash-zxmvrrptsvoo
branch
from
September 23, 2026 20:09
5ce541c to
dc29482
Compare
akundaz
changed the title
avalonche
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deposits should be force-included from L1 and not subject to per-transaction gas limits. This was only being followed in the building path, not the syncer.