sys-apps/ignition: Version bump to 2.27.0 - #4262
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The build-time CoreOS→Flatcar sed rewrite uses \b in a way that is likely a no-op in sed (breaking the rename), and the changelog includes an incorrect 2.25.1 release-notes fragment link.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Bumps the Flatcar overlay’s sys-apps/ignition package to 2.27.0, while reducing downstream patching by switching the big CoreOS→Flatcar rename from a stored patch to a build-time substitution. Also updates coreos-init to a newer Flatcar init snapshot and amends the (not-yet-released) changelog entry accordingly.
Changes:
- Update Ignition distfile/ebuild to 2.27.0 and refresh the downstream patch stack (including dropping several patches that appear to be upstream now).
- Replace the previous rename patch with a
src_prepare()sedrewrite (currently implemented in a way that likely does not apply the rewrite). - Bump
coreos-initsnapshot and update the user-facing changelog entry.
File summaries
| File | Description |
|---|---|
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/Manifest | Updates Ignition distfile to 2.27.0 with new size/checksums. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/ignition-9999.ebuild | Drops the old rename patch and introduces build-time rewrite of CoreOS import paths. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/ignition-2.27.0.ebuild | Adds the 2.27.0 ebuild with the refreshed patch set and build-time rewrite. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0001-config-add-ignition-translation.patch | Patch header/content adjustments to match updated patch series and upstream context. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0002-mod-add-flatcar-ignition-0.36.2.patch | Patch header/content adjustments and dependency updates for converter support. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0003-config-v3_7-convert-ignition-2.x-to-3.x.patch | Patch header/content adjustments for the updated upstream tree. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0004-internal-prv-cmdline-backport-flatcar-patch.patch | Replaces prior cmdline provider backport patch with renumbered/updated version. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0005-provider-qemu-apply-fw_cfg-patch.patch | Patch header/content adjustments for QEMU fw_cfg compatibility changes. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0006-internal-disk-fs-ignore-fs-format-mismatches-for-the.patch | Patch header/content adjustments for OEM filesystem handling. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0007-VMware-Fix-guestinfo.-.config.data-and-.config.url-v.patch | Patch header/content adjustments for VMware guestinfo behavior. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0008-config-version-handle-configuration-version-1.patch | Patch header/content adjustments for config version detection. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0009-config-util-add-cloud-init-detection-to-initial-pars.patch | Patch header/content adjustments for cloud-init detection changes. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0010-translation-support-OEM-and-oem.patch | Patch header/content adjustments for OEM translation behavior. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0011-internal-exec-stages-mount-Mount-oem.patch | Patch header/content adjustments for OEM mount location behavior. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0012-go-mod-vendor.patch | Patch header/content adjustments and vendor/modules.txt updates. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0013-Partially-revert-drop-OEM-URI-support.patch | Patch header/content adjustments for OEM URI support changes. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0014-config-Support-oem-schema-in-newer-config-spec-versi.patch | Patch header/content adjustments for oem:// schema support across config versions. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0015-usr-share-oem-oem.patch | Patch header/content adjustments for /usr/share/oem → /oem migration. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0006-internal-prv-cmdline-backport-flatcar-patch.patch | Removes obsolete/renumbered patch from the patch stack. |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0017-stages-disks-Fix-handling-of-device-mapper-when-part.patch | Drops downstream disk/partitioning patch (presumably upstreamed). |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0018-stages-disks-Fix-giving-partition-number-0-to-get-th.patch | Drops downstream disk/partitioning patch (presumably upstreamed). |
| sdk_container/src/third_party/coreos-overlay/sys-apps/ignition/files/0019-stages-disks-Allow-partx-to-fail-then-check-the-stat.patch | Drops downstream disk/partitioning patch (presumably upstreamed). |
| sdk_container/src/third_party/coreos-overlay/coreos-base/coreos-init/Manifest | Updates coreos-init snapshot distfile size/checksums. |
| sdk_container/src/third_party/coreos-overlay/coreos-base/coreos-init/coreos-init-9999.ebuild | Bumps EGIT_VERSION to a newer Flatcar init snapshot tarball. |
| changelog/updates/2026-08-26-ignition.md | Updates the changelog entry to reference Ignition 2.27.0 release notes. |
Review details
- Files reviewed: 24/26 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tormath1
left a comment
There was a problem hiding this comment.
LGTM. For what is worth, we usually run tests on all supported platforms when upgrading Ignition (as it usually impacts all cloud providers). As we upgrade recently to 2.26.0, we should be OK - let's see in nightlies. :)
This drops the big flatcar -> coreos rename patch in favour of running sed at build time. Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
8c6847c to
8bb0435
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The new build-time sed rewrite in src_prepare() should avoid traversing .git/ in live builds to prevent unnecessary work and potential corruption/slowdowns.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 24/27 changed files
- Comments generated: 1
- Review effort level: Lite
|
|
||
| src_prepare() { | ||
| default | ||
| find -type f -print0 | xargs -0 sed -i "s:\bgithub\.com/coreos/ignition\b:github.com/flatcar/ignition:g" || die |
This drops the big flatcar -> coreos rename patch in favour of running
sedat build time. Some of my earlier patches were applied upstream.This amends the existing changelog entry because we haven't done a release with 2.26.0 yet.
This also bumps coreos-init for the fix in flatcar/init#146.
Note: This doesn't include my proposed
file://schema addition. That will come later.How to use
Just provision as usual. You can now also pass Butane YAML instead of Ignition JSON directly! 😮
Testing done
Jenkins passed, except for azure due to the coreos-init issue, which I didn't fix until later. I also tested provisioning with PXE using the
oem://schema.Despite now bundling Butane inside Ignition, the Ignition binary actually shrank by 19MB. This is because upstream dropped the Google Cloud Storage dependencies in favour of direct HTTP.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.