fix: stabilize coverage and release detection - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the two independent failures encountered after merging the 1.3.0 release PR.
Evidence and validation
The passing PR and failing main run have identical source trees. The passing coverage run used Xdebug 3.5.3; the failing run loaded 3.6.0alpha1 and reported 51.49% branch coverage while all tests and line coverage passed. The separate release workflow skipped publication because GitHub had not yet returned the merged release PR; the API now associates the same commit with PR #11.
Local validation:
Release handling
No source API behavior, dependency lock, version, or published tag changes. This is a normal fix branch and does not itself qualify as a release branch. After these repairs are merged, the still-unpublished 1.3.0 needs a fresh reviewed release PR containing the repaired workflow; rerunning the old run uses its original workflow. Publication remains behind the existing validation and release environment gates.
Related runs: https://github.com/fleetbase/fleetbase-php/actions/runs/34431966656 and https://github.com/fleetbase/fleetbase-php/actions/runs/34431966856