Conversation
…is set Dropdown.expanded_insets was declared in the Python API but never read by the Flutter client: expandedInsets was derived only from expand (EdgeInsets.zero whenever expand was set, ignoring expanded_insets entirely). Read expanded_insets via the same getPadding helper used for content_padding elsewhere in this control, falling back to EdgeInsets.zero when unset, matching prior behavior. Fixes flet-dev#6895
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropdown.expanded_insetswas declared in the Python SDK but never read by the Flutter client, so an expanded dropdown always used zero insets. Reads it via the existinggetPaddinghelper whenexpandis set, falling back to zero insets when unset; added 3 widget tests and a changelog entry.Fixes #6895