Skip to content

fix(dropdown): apply expanded_insets to the DropdownMenu when expand is set - #6896

Open
xsalaices wants to merge 1 commit into
flet-dev:mainfrom
xsalaices:fix/6895-dropdown-expanded-insets
Open

xsalaices wants to merge 1 commit into
flet-dev:mainfrom
xsalaices:fix/6895-dropdown-expanded-insets

Conversation

@xsalaices

@xsalaices xsalaices commented Sep 28, 2026 •

Copy link
Copy Markdown

Dropdown.expanded_insets was declared in the Python SDK but never read by the Flutter client, so an expanded dropdown always used zero insets. Reads it via the existing getPadding helper when expand is set, falling back to zero insets when unset; added 3 widget tests and a changelog entry.

Fixes #6895

…is set

Dropdown.expanded_insets was declared in the Python API but never read
by the Flutter client: expandedInsets was derived only from expand
(EdgeInsets.zero whenever expand was set, ignoring expanded_insets
entirely).

Read expanded_insets via the same getPadding helper used for
content_padding elsewhere in this control, falling back to
EdgeInsets.zero when unset, matching prior behavior.

Fixes flet-dev#6895

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown.expanded_insets has no effect

1 participant