Repository navigation
Remove more unused spec setup - #1055
Merged
Merged
Conversation
Follow-up to #1053. None of these ever had a reader; the build_feature lets would raise NameError if evaluated, since build_feature was never defined. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1053. This removes the rest of the spec setup that nothing reads. Git history shows none of it ever had a reader. Each piece was unused from the commit that added it.
ui/decorators/gate_spec.rb:sourceandadapter. Both have been there since UI was merged into the repo in 2015, and the specs have always usedbuild_flipper. This is the same pattern Remove unused lets from specs聽#1053 removed fromfeature_spec.rb.ui/actions/settings_spec.rb:tokenandsession. This CSRF setup was copied in when the settings page was created. The other UI action specs pass it into POST requests, but this spec only does aGET.api/v1/actions/feature_spec.rbandfeatures_spec.rb:let(:feature) { build_feature }(andgate, which is built on it). They date from the initial API specs in 2016.build_featurehas never been defined, so they would raiseNameErrorif anything read them. Nothing does, so they never ran.cloud/telemetry/submitter_spec.rb:with_telemetry_debug_logging. It was added in 51d72288, and the same commit rewrote the retry specs to assert onFakeBackoffPolicyinstead of log output, so the helper never had a caller.Found with trekr
--dead specand checked by hand.bundle exec rakeis green.馃 Generated with Claude Code