Repository navigation
Remove unused private methods - #1056
Merged
Merged
Conversation
dpep
marked this pull request as ready for review
October 3, 2026 22:21
dpep
changed the title
Collaborator
|
Sorry forgot about this one. I'll get it reviewed. Gotta check if these are here for cloud to override. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two private methods in the API actions that nothing calls. Git history shows when each lost its last caller.
Flipper::Api::Action#path_parts: its last caller wasfeature_name, until 1602d2e1 (2018, "Add support for slashes in feature names to API") moved feature names to the route.Flipper::Api::V1::Actions::GroupsGate#disallow_unregistered_groups?: fa80cc33 (2017, "Make rubo happy") rewrote its only caller to useallow_unregistered_groups?directly.Both are private, so nothing outside the gem can call them. Found with trekr
--dead lib(testing out a new tool I'm working on 馃槈)