Conversation
5 tasks
Picks up flame-engine/flame#4051, which fixes the solveQuadratic random test tolerance that made the customer test fail for some seeds, and flame-engine/flame#4052, which pins the randomized tests to a fixed seed in the customer testing run so it stays deterministic.
spydon
force-pushed
the
flame-update-hash
branch
from
September 22, 2026 07:36
c9081d9 to
519deef
Compare
jtmcdole
approved these changes
Sep 23, 2026
jtmcdole
left a comment
Member
There was a problem hiding this comment.
💵 The CodeFu 1024-Note: Collector's Edition
The LGTM exchange rates are currently trading at:
- 1 LGTM = Golden images match closely enough if I squint.
- 2 LGTMs = I checked that this won't break the devicelab benchmarks.
- 3 LGTMs = I trust that this C++ pointer won't leak memory every frame.
- 4 LGTMs = CI is green on the first try without a single retry or shard failure.
💵 Value officially backed by the full faith, credit, and compute budget of the Flutter EngProd Infrastructure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Updates the pinned commit for
registry/flame.testfrom74721f09toc35f9d80, the current head offlame-engine/flamemain.This picks up two changes that make the Flame customer test deterministic:
test: Loosen the residual tolerance in the solveQuadratic random test flame-engine/flame#4051 fixes the
solveQuadratic solve random equationtest. Its residual tolerance only scaled with the leading coefficient, so seeds that produced a root with a large magnitude failed even though the solver result was within two ulps of the largest term. That is what caused the recent customer test failure:feat: Lock random seeds in the flutter/tests customer testing run flame-engine/flame#4052 pins all of Flame's randomized tests to a fixed seed when they are run through
scripts/customer_testing.dart, so this run can no longer fail on a seed that has nothing to do with the framework change under test. Flame's own CI keeps running them with fresh seeds.