Update provider to get decoupling fix, and re-enable it - #498
Conversation
|
autosubmit label was removed for flutter/tests/498, because - The status or check suite windows_tests (shard 2 of 5, 1) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
|
There is a failure happening on Windows due to a stack overflow in the test "supports a large number of providers". I suspect it might be intermittent due to low memory, but I got the failure twice in a row, so it's probably not something we should land. I've opened a PR to disable the provider tests until it's resolved (#501). I'll leave this PR open until it lands in case I'm able to resolve it. |
|
I've opened an issue in the provider repo about this: rrousselGit/provider#925 FYI @rrousselGit |
I'm trying to deprecate Material and Cupertino in flutter/flutter#192957. One of the things I was blocked on was that provider had not yet migrated. Now that it is migrated (rrousselGit/provider#924), this PR bumps the SHA, and the customer tests should pass in my migration PR. Related: * #498 * #500
I'm trying to deprecate Material and Cupertino in flutter/flutter#192957. One of the things I was blocked on was that provider had not yet migrated. Now that it is migrated (rrousselGit/provider#924), this PR bumps the SHA, and the customer tests should pass in my migration PR. Related: * #498 * #499
|
And here's my PR in provider that solves the problem by skipping the test: rrousselGit/provider#926 |
This PR disables the provider tests because of a stack overflow happening on Windows after migrating to material_ui. * rrousselGit/provider#924 * #498
|
rrousselGit/provider#926 has been closed. I will skip the test in the test command here and enable the tests instead. |
As advised by the author of the package. I'm skipping it on all platforms instead of just on Windows as a safety measure. I imagine some other platforms may fail flakily due to resource constraints at some point, so let's avoid that.
justinmc
changed the title
2 participants
I'm trying to deprecate Material and Cupertino in flutter/flutter#192957. One of the things I was blocked on was that
providerhad not yet migrated. Now that it is migrated (rrousselGit/provider#924), this PR bumps the SHA, and the customer tests should pass in my migration PR.Related: