Skip to content

Run go fix as part of make test and CI - #2190

Open
andrearcaina wants to merge 2 commits into
fluxcd:mainfrom
andrearcaina:ci/go-fix-modernization
Open

andrearcaina wants to merge 2 commits into
fluxcd:mainfrom
andrearcaina:ci/go-fix-modernization

Conversation

@andrearcaina

Copy link
Copy Markdown

Part of fluxcd/flux2#6120

  • Applies go fix ./... changes to the root and api directory
  • Run go fix ./... as part of make test command

Validation:

  • make test-api passes
  • make test ran into some local OCI failures for me

Signed-off-by: Andre Arcaina <dtandre331@gmail.com>
@matheuscscp matheuscscp added the hold Issues and pull requests put on hold label Oct 19, 2026
@matheuscscp

Copy link
Copy Markdown
Member

Hey @andrearcaina thanks again! I'm gonna hold this PR and any others related to this issue for a couple of weeks. We are about to release Flux 2.10 in one week, and since the go fix changes are quite massive (despite hopefully harmless 🤞) I prefer to reduce the release risk.

@andrearcaina

Copy link
Copy Markdown
Author

Hey @matheuscscp, no worries! Good luck with the release!

Signed-off-by: andre arcaina <dtandre331@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Issues and pull requests put on hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants