Repository navigation
Conversation
… with the top one
ako3131
requested review from
santipalenque and
smarcet
and
a balanced review from Copilot
October 19, 2026 18:36
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
Author
|
/deploy-preview |
|
🚀 Deployed on https://pr-1131--show-admin-preview.netlify.app |
There was a problem hiding this comment.
🟡 Changes recommended
Bulk-edit relationship handling and unresolved search, visibility, and keyboard interaction defects affect core activity-list workflows.
5 open issues
What changed in this PR
Migrates the activity list to MUI Data Grid and consolidates its controls into a toolbar.
Changes:
- Adds resizable columns, bulk editing, and top/bottom pagination.
- Introduces searchable Saved Views and optional-column persistence.
- Adds grid and saved-view interaction tests.
| File | Description |
|---|---|
| yarn.lock | Locks Data Grid dependencies. |
| src/reducers/events/event-list-reducer.js | Stores optional-column selections. |
| src/pages/events/summit-event-list-page/index.js | Integrates the grid and Saved Views. |
| src/pages/events/summit-event-list-page/helpers.js | Makes Selection Status optional. |
| src/pages/events/__tests__/summit-event-list-page.test.js | Tests column visibility and persistence. |
| src/i18n/en.json | Updates toolbar and saved-view labels. |
| src/components/mui/bulk-edit-data-grid.js | Adds the reusable bulk-edit grid. |
| src/components/mui/__tests__/bulk-edit-data-grid.test.js | Tests grid interactions. |
| src/components/filters/saved-views/index.js | Adds saved-view selection and management. |
| src/components/filters/saved-views/__tests__/saved-views.test.js | Tests saved-view workflows. |
| src/actions/event-actions.js | Adds the column-selection action. |
| package.json | Adds MUI Data Grid. |
Review effort: Balanced
| const editField = (rowId, key, value) => { | ||
| setEditRows((current) => ({ | ||
| ...current, | ||
| [rowId]: { ...current[rowId], [key]: value } |
Comment on lines
+158
to
+159
| const loadViews = (input) => | ||
| queryFilterCriterias(summitId, context, input, setViews); |
| onChange={handleSearch} | ||
| placeholder={T.translate("general.placeholders.search")} | ||
| // the menu otherwise treats typing as item navigation | ||
| onKeyDown={(ev) => ev.stopPropagation()} |
| // its input and its clear button with nothing typed | ||
| onBlur={(ev) => { | ||
| if (ev.currentTarget.contains(ev.relatedTarget)) return; | ||
| if (!ev.currentTarget.querySelector("input").value) setExpanded(false); |
Comment on lines
+489
to
+491
| field: "actions", | ||
| type: "actions", | ||
| headerName: T.translate("general.actions"), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/9014802374/86bcbg72u
UI CHANGES: