Repository navigation
Refactor/selected speaker event activity dropdowns - #1135
Merged
ako3131 merged 13 commits intoOct 23, 2026
Merged
Conversation
… out the plain events
…ivity type and category
…tivity type change
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues in the dropdown changes or accompanying tests; tests were not executed.
No open issues 🎉
What changed in this PR
Refines activity dropdowns so category and selection-plan choices reflect the selected activity type.
Changes:
- Groups categories and filters selection plans by compatibility.
- Clears incompatible plans after changes while preserving saved plans on load.
- Prevents saved presentation downgrades and adds regression coverage.
| File | Description |
|---|---|
| src/i18n/en.json | Adds dropdown labels and removes obsolete downgrade text. |
| src/components/forms/event-form/index.js | Updates dropdown layout, matching, and selection handling. |
| src/components/forms/event-form/__tests__/event-form.test.js | Tests matching, saved selections, type restrictions, and error-prop immutability. |
| src/components/forms/event-form/__tests__/event-form-notify.test.js | Updates selection-plan fixtures with event types. |
Review effort: Balanced
santipalenque
approved these changes
Oct 23, 2026
santipalenque
left a comment
santipalenque
left a comment
There was a problem hiding this comment.
LGTM , I added a guard on track to prevent a crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/9014802374/86bcgwtr3
UI Changes:
disabledflag was ignored by react-select, so the now-unreachable downgrade popup is removed.handleChangeSelectionPlancopieserrorsinstead of writing into the parent's prop.