Skip to content

fix: destructure tag object on formatOption on allowed tags ddl - #1137

Open
tomrndom wants to merge 1 commit into
masterfrom
fix/event-category-allowed-tag-fix
Open

tomrndom wants to merge 1 commit into
masterfrom
fix/event-category-allowed-tag-fix

Conversation

@tomrndom

@tomrndom tomrndom commented Oct 22, 2026 •

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bcpry2f

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Other
    • No user-facing changes. Tag suggestions continue to display the same labels and values, and the available autocomplete functionality remains unchanged. This update does not alter how users interact with event categories or affect any other visible features.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom self-assigned this Oct 22, 2026
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 09d78454-6897-4b76-80cb-3e2759f87942
📥 Commits

Reviewing files that changed from the base of the PR and between 0fbae23 and 2b2f345.

📒 Files selected for processing: 1
  • src/components/forms/event-category-form.js

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The tag autocomplete’s formatOption callback now reads tag from an object argument. It creates the same option value and label.

Changes: Tag autocomplete

Layer / File(s) Summary
Read tag from callback argument
src/components/forms/event-category-form.js
formatOption now destructures tag from its argument. The produced option’s value and label are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: santipalenque

Merge Risk: ⚪ Minimal · up to 2b2f3

The change is limited to adapting the callback argument shape and is ready to merge.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: destructuring the tag object in the allowed-tags dropdown's formatOption callback.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@santipalenque santipalenque left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants