Repository navigation
fix(ci): merge validated ingest pull requests automatically - #366
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ingestion workflow now runs checks when it detects changes. It records the pushed commit SHA, conditionally squash-merges the target branch, and explicitly dispatches Pages deployment. ChangesIngestion workflow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The workflow validates ingestion updates before merging and explicitly starts Pages deployment afterward. No actionable merge-blocking risk was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5801f47f42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| GH_TOKEN: ${{ github.token }} | ||
| BRANCH_NAME: ${{ steps.target-branch.outputs.branch-name }} | ||
| HEAD_SHA: ${{ steps.push-changes.outputs.head-sha }} | ||
| run: gh pr merge "$BRANCH_NAME" --repo "$GITHUB_REPOSITORY" --squash --match-head-commit "$HEAD_SHA" |
There was a problem hiding this comment.
When ingestion produces schema-valid but semantically incorrect data, this unconditional merge publishes it without review. docs/plans/active/direct-main-ingestion.md lines 18-56 documents material errors still caught by review—including seven automated PRs rejected entirely—and says the current detectors miss incorrect scopes, effects, periods, issue matching, and relevance; none of the newly added deterministic commands supplies the planned semantic guards, quarantine, or source-eligibility gate. Retain review or implement those gates before merging every ingest result automatically.
AGENTS.md reference: AGENTS.md:L106-L107
Useful? React with 👍 / 👎.
| GH_TOKEN: ${{ github.token }} | ||
| BRANCH_NAME: ${{ steps.target-branch.outputs.branch-name }} | ||
| HEAD_SHA: ${{ steps.push-changes.outputs.head-sha }} | ||
| run: gh pr merge "$BRANCH_NAME" --repo "$GITHUB_REPOSITORY" --squash --match-head-commit "$HEAD_SHA" |
There was a problem hiding this comment.
When main advances after checkout while model calls and tests are running, this command merges a head validated against the old base into the new main. As confirmed by gh pr merge --help, --match-head-commit only requires that the pull-request head match the supplied SHA; it does not pin the base, and the ingestion concurrency group does not block unrelated merges. Thus non-conflicting schema and data changes can produce a combined tree that was never validated, contrary to the discard-and-rerun requirement in docs/plans/active/direct-main-ingestion.md lines 301-303; capture the starting main SHA and rerun if it changes before merging.
AGENTS.md reference: AGENTS.md:L106-L107
Useful? React with 👍 / 👎.
2 participants
Summary
GITHUB_TOKENdoes not trigger apushworkflow.Why
gh pr merge --autofailed on a clean PR becausemainhas no required merge conditions. PR workflows created withGITHUB_TOKENrequire manual approval, so making those checks required would not provide unattended merges.Verification
npm run lintnpm run checknpm run build:packagesnpm run fixtures:validateTZ=UTC npm test(372 tests)TZ=UTC npm run test:packagesnpm run pages:buildnpm run data:validategit diff --checkSummary by CodeRabbit