fix: check for DENOMINATOR subexpressions or dirty args before marking clean - #912
Merged
Merged
Conversation
…g clean Additionally, TestFunFlag must scan DENOMINATOR and EXPONENT arguments for subexpressions, or for e.g. replace_ can run too early and miss replacements. The resolves form-dev#316 and form-dev#315
jodavies
changed the title
|
coverage: 66.0% (+0.03%) from 65.972% — jodavies:issue-316 into form-dev:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, TestFunFlag must scan DENOMINATOR and EXPONENT arguments for subexpressions, or for e.g. replace_ can run too early and miss replacements.
The resolves #316 and #315