Repository navigation
Add a dedicated error for devices without the button press - #1202
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds
LaMetricUnsupportedError, raised byLaMetricLocalAuth.request_challenge()when the device does not support getting its API key with a press on its button (like an LM 37X8 TIME, which answers with a 401).Until now that case was a plain
LaMetricError, just like an unexpected or broken answer from the device. A caller could not tell "this device cannot do this" apart from "something went wrong", so Home Assistant would tell the user their device does not support the button for any failure.The new error subclasses
LaMetricError, so existing code catchingLaMetricErrorkeeps working. Every other failure stays a plainLaMetricError, and a test now guards that.Verified on the real LM 37X8 TIME (firmware 2.3.9):
request_challenge()raisesLaMetricUnsupportedError, which is still aLaMetricError.Related Issues
Raised in review on home-assistant/core#184197. Follow up on #1199.