[seanspeaks]

Stack 9 of 9. Stacked on #699.

Summary

The api-module-library PRs implement the methods that PR 7's audit found missing:

• feat(hubspot): 15 methods that Frigg's capability manifest relies on api-module-library#106: HubSpot
• feat(salesforce): implement the capability methods the Frigg manifest relies on api-module-library#107: Salesforce
• feat(stripe): customer, payment intent, refund and payout methods api-module-library#108: Stripe
• feat(linear): issue, comment, attachment, team and workflow-state methods api-module-library#109: Linear
• feat: Asana task search and webhooks, Pipedrive person writes, Fathom webhook delete, Slack users.list api-module-library#110: Asana, Pipedrive, Fathom, Slack

All of them are stacked on #105.

This PR points the manifests at those methods:

• Unimplemented, before → after: HubSpot 17 → 0, Salesforce 7 → 0, Stripe 8 → 0, Linear 9 → 0, Asana 3 → 0, Pipedrive 2 → 0, Fathom 1 → 0, Slack 1 → 0.
• Each capability now has args that match the real signature.
• Salesforce webhook verification stays unimplemented.
• HubSpot deal.search is reshaped to the real searchDeals({ filterGroups, ... }). The old open/closeDate/minAmount inputs never existed.
• Fix: HubSpot searches return { total, results, paging }. The examples now read steps.<id>.results, as the sync engine already did. hubspot-slack's close-date filter sends epoch ms seven days ahead instead of the mock-era "+7d".
• AUDIT.md has the per-module re-run commands and the PR links.

Merge order. A definition that uses these capabilities needs the module releases, so merge the api-module-library PRs first.

Test plan

• check-manifests.js, run once per module against the module branches, reports nothing unimplemented except Salesforce webhook verification.
• npx jest packages/core/integrations/definitions: 221 pass, 14 skipped.
• Same 31 pre-existing failures as next in the core run. Nothing new fails.
• Not done yet: one definition per module run against a real account.

---

Generated by Claude Code

---

Note

Medium Risk
Broad manifest and example-definition changes (especially HubSpot search/update shapes) can break workflows until callers adopt .results and new inputs; runtime also depends on unreleased api-module-library releases or calls fail with missing methods.

Overview
Updates integration capability manifests for Asana, Fathom, HubSpot, Linear, Pipedrive, Salesforce, Slack, and Stripe so they match api-module-library methods from PRs #106–#110: drops prior unimplemented flags, wires args for real positional signatures, and refreshes AUDIT.md (per-module check-manifests runs and audit tables).

HubSpot is the breaking shape change: deal.search now uses HubSpot filterGroups (replacing mock open / close-date / minAmount), deal.update expects dealId, and contact/deal/task searches declare paged { total, results, paging } outputs. Example definitions (hubspot-slack, fathom-hubspot-notion, phone-hubspot) and tests now read $.steps.*.results and mock paginated API responses; createCallEngagement is asserted as (properties, contactId).

Salesforce webhook verification stays unimplemented; Phone contact.search remains the main bundled unimplemented capability (validator tests adjusted accordingly).

^{Reviewed by Cursor Bugbot for commit 80ec1cc. Bugbot is set up for automated code reviews on this repo. Configure here.}

📦 Published PR as canary version: 2.0.0--canary.700.80ec1cc.0

✨ Test out this PR locally via:

npm install @friggframework/admin-scripts@2.0.0--canary.700.80ec1cc.0
npm install @friggframework/core@2.0.0--canary.700.80ec1cc.0
npm install @friggframework/devtools@2.0.0--canary.700.80ec1cc.0
npm install @friggframework/eslint-config@2.0.0--canary.700.80ec1cc.0
npm install @friggframework/prettier-config@2.0.0--canary.700.80ec1cc.0
npm install @friggframework/schemas@2.0.0--canary.700.80ec1cc.0
npm install @friggframework/serverless-plugin@2.0.0--canary.700.80ec1cc.0
npm install @friggframework/test@2.0.0--canary.700.80ec1cc.0
npm install @friggframework/ui@2.0.0--canary.700.80ec1cc.0
# or 
yarn add @friggframework/admin-scripts@2.0.0--canary.700.80ec1cc.0
yarn add @friggframework/core@2.0.0--canary.700.80ec1cc.0
yarn add @friggframework/devtools@2.0.0--canary.700.80ec1cc.0
yarn add @friggframework/eslint-config@2.0.0--canary.700.80ec1cc.0
yarn add @friggframework/prettier-config@2.0.0--canary.700.80ec1cc.0
yarn add @friggframework/schemas@2.0.0--canary.700.80ec1cc.0
yarn add @friggframework/serverless-plugin@2.0.0--canary.700.80ec1cc.0
yarn add @friggframework/test@2.0.0--canary.700.80ec1cc.0
yarn add @friggframework/ui@2.0.0--canary.700.80ec1cc.0

[claude]

⚠️ Code review skipped — your organization has no extra usage available to pay for this review.

If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.

Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.

[seanspeaks]

ADR reconciliation needed after Stack A/B — drafted with Claude Code at Sean's request

Severity: cross-ref only.

• The methods added in api-module-library add lookupUsersByEmail #106–IRON-17518 Vedantagrawall/ironclad comments endpoint #110 should also be declared in each module's Definition.capabilities (ADR-020 implementedBy: { kind: 'api-class-method', ref }, plus ADR-045 traits where they apply), so manifests can be generated from or checked against the module (see the ADR-020 amendment proposed on feat(core): capability manifests checked against the real API modules #698). Otherwise the args fixed here are one more copy to keep in sync.
• The HubSpot deal.search reshape and the { total, results, paging } return are paging facts too. Record them in the module's ADR-054 §6 objects descriptor or ADR-045 traits, not only in the manifest.
• Merge order stays as the PR body says: api-module-library adding workflow participants and get user endpoints #105–IRON-17518 Vedantagrawall/ironclad comments endpoint #110 → feat(core): capability manifests checked against the real API modules #698 (with the 020 amendment) → this PR.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 80ec1cc. Configure here.}

[cursor]

Mock-era dates reach live APIs

Medium Severity

This PR marks search capabilities implemented and converts hubspot.deal.search's mock-era +7d to epoch ms, but leaves dueBefore: "+1d" on hubspot.task.search and lastContactedBefore: "-30d" on hubspot.contact.search in the same examples. asana.task.search is now a live $rest pass-through while asana-slack still sends due_on: "+1d". Vendor search APIs expect real timestamps or YYYY-MM-DD, so those workflows can return no matches after the module releases land.

Additional Locations (2)

• packages/core/integrations/definitions/examples/phone-hubspot.definition.json#L375-L377
• packages/core/integrations/definitions/capabilities/asana.capabilities.json#L197-L201

 

^{Reviewed by Cursor Bugbot for commit 80ec1cc. Configure here.}

[cursor]

Stack B review (COMMENT only) — Group 4

Verdict (would merge?): would approve

Should-fix

• Manifests mark new methods OK while depending on api-module-library releases (add lookupUsersByEmail #106–IRON-17518 Vedantagrawall/ironclad comments endpoint #110 / adding workflow participants and get user endpoints #105 and peers). Merge this Frigg PR before those module releases → runtime api[method] is not a function (including verify paths). Honour the stated merge order / pin module versions.

Nits

• AUDIT.md still claims hubspot-slack indexes $.steps.deals[0] as a page object; example already uses .results in this PR — stale audit note.

No blocking items (assuming module PRs land first).

[cursor]

[should-fix] Documented here: manifests describe methods that only exist on unmerged api-module-library PRs. Merging this Frigg PR first → runtime "not a function". Honour merge order / pin module releases. Top-level Stack B COMMENT summary has the full verdict (would approve, no blockers if modules land first).