ci: add pull-request checks, and make main pass them - #17
Merged
Merged
Conversation
`main` was not rustfmt-clean: `cargo fmt --all -- --check` reported 19 hunks across `build/expr.rs` and `resolve/mod.rs`. Every incoming patch that touched those files had to choose between leaving them unformatted and burying its change in unrelated reformatting. This commit is the output of `cargo fmt --all` with no manual edits, so that the formatting gate added alongside it starts green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`Statement::UnlockTables` is a unit variant, so matching it as
`UnlockTables { .. }` triggered clippy's `unneeded_struct_pattern`. This
was the only warning on `main`, and it had to go before the clippy gate
could run with `-D warnings`.
No behavior change: the arm already mapped to `StatementType::Other`.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The repository had no pull-request CI. `release.yml` only triggers on
version tags, so nothing checked a branch until it was already being
released, and every incoming patch had to be verified by hand.
Four jobs, all on `ubuntu-latest`:
- `rustfmt` — `cargo fmt --all --check`
- `clippy` — `--workspace --all-targets --all-features -- -D warnings`
- `test` — `cargo test --workspace --all-features`
- `python` — builds the wheel with maturin and runs the same smoke
test as `release.yml`, so a broken PyO3 binding fails on
the pull request rather than on the release tag
`clippy` and `test` set up Python because `sqllineage-python` is a
workspace member and links against libpython at build time. Cross-platform
and multi-version coverage stays in `release.yml`; this workflow is the
fast gate, not a replacement for it.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Dependabot only watched GitHub Actions, so `sqlparser`, `pyo3`, `clap`, and `serde` were never proposed for update. `sqlparser` in particular gates which dialects and syntax the crate can support, so noticing a new release matters here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for working through the contributions in #15.
What
style: apply rustfmt to the workspacecargo fmt --all, no manual editsfix: drop unneeded struct pattern on a unit variantStatement::UnlockTables { .. }→Statement::UnlockTablesci: run fmt, clippy, tests, and a Python smoke test on pull requests.github/workflows/ci.yml+ README badgeci: let dependabot track cargo dependenciescargoecosystem alongsidegithub-actionsNo behavior change.
Why
release.ymlonly triggers on version tags, so branches were unverified until release time.mainwas not rustfmt-clean — 19 hunks inbuild/expr.rsandresolve/mod.rs. Formatting noise leaks into unrelated diffs; fix: two column lineage correctness bugs (nondeterministic ordering, fabricated origins) #12 skippedcargo fmtfor this reason and fix: harden column lineage resolution and performance #14 carries a reformat commit mid-stack.main, which blocked running the gate with-D warnings.sqlparser/pyo3/clap/serde.Workflow
Four jobs on
ubuntu-latest, onpull_requestand pushes tomain:rustfmt—cargo fmt --all --checkclippy—--workspace --all-targets --all-features -- -D warningstest—cargo test --workspace --all-featurespython— maturin wheel build + the same smoke test asrelease.ymlclippyandtestset up Python becausesqllineage-pythonis a workspace member that links against libpython. Cross-platform and multi-version coverage stays inrelease.yml.Verified locally
Open
Cargo.lockis gitignored. Committing it would make CI reproducible for the shipped binary — separate call, not included here.🤖 Generated with Claude Code