Skip to content

fix: update Cython dependency to avoid ABI collisions and add warning on fail - #60

Merged
tlambert03 merged 1 commit into
funkelab:mainfrom
tlambert03:fix-abi-collision
Sep 9, 2026
Merged

tlambert03 merged 1 commit into
funkelab:mainfrom
tlambert03:fix-abi-collision

Conversation

@tlambert03

@tlambert03 tlambert03 commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

this fixes a bug that @funkey observed (as a result of using spatial graph after having imported another cp310 abi3 module built by the same version of cython, which in his case was uharfbuzz 0.56.0)

this is a known bug/regression in cython 3.3.0: cython/cython#7914

which has been fixed, but not yet released. fix here is to block that version of cython. and fall back to compilation (rather than raise a TypeError) when we see it again

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.72%. Comparing base (7d289b0) to head (2aadceb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   95.71%   95.72%           
=======================================
  Files          14       14           
  Lines         443      444    +1     
=======================================
+ Hits          424      425    +1     
  Misses         19       19           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Sep 9, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing tlambert03:fix-abi-collision (2aadceb) with main (7d289b0)

Open in CodSpeed

@tlambert03
tlambert03 merged commit 08d46be into funkelab:main Sep 9, 2026
29 checks passed
@tlambert03
tlambert03 deleted the fix-abi-collision branch September 9, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants