Skip to content

macos 下从url导入文件功能用不了 #77

Closed

Description

@gaoconggit

@claude 解决它

Activity

  1. claude commented on Nov 12, 2025

    @claude

    Claude finished @gaoconggit's task —— View job • claude/issue-77-20251112-1542 • Create PR ➔


    Fixed macOS URL Import Issue ✓

    I've successfully fixed the issue! The problem was that on macOS (when using the desktop version), the code was bypassing the import method selection dialog and forcing the use of desktop bridge, which only supports file selection.

    Root Cause:
    In fileManager.js:1286-1288, when shouldUseDesktopImport() returned true (which happens on macOS with desktop bridge), it immediately called importFolderViaDesktopBridge() and returned, preventing users from choosing URL import.

    The Fix:
    I've reordered the logic in the importFolder() method to:

    1. First, show the import method selection dialog to the user
    2. If URL import is selected, use the standard importFromUrl() method (works on all platforms)
    3. If file import is selected, use desktop bridge on macOS, or standard file input on other platforms

    Changes Made

    • Modified fileManager.js:1275-1302 to always show the import method selection dialog first
    • Desktop bridge is now only used for file imports when available
    • URL imports now work consistently across all platforms, including macOS

    Testing

    The fix ensures that:

    • ✅ On macOS, users can now choose between file and URL import
    • ✅ URL import works the same way across all platforms
    • ✅ File import still uses the native desktop bridge on macOS for a better user experience
    • ✅ Other platforms are unaffected

    | Branch: claude/issue-77-20251112-1542

  2. added a commit that references this issue on Nov 12, 2025
    c1c36f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions