Skip to content

Chore/tabhost leftover ids - #10

Closed
letharion wants to merge 10 commits into
gerhardol:masterfrom
letharion:chore/tabhost-leftover-ids
Closed

letharion wants to merge 10 commits into
gerhardol:masterfrom
letharion:chore/tabhost-leftover-ids

Conversation

@letharion

Copy link
Copy Markdown

Removal of assorted leftovers that are unused after the tabhost removal.

roberi and others added 10 commits September 13, 2026 19:09
Fix an issue where bundled workouts were not copied to internal storage on fresh installs.

- In `MainLayout.handleBundled()`, initialized `dstDir` using `dst` (the target subdirectory) instead of `dstBase` (the parent directory) so subdirectories like `app_workouts` are properly created.
- Updated SharedPreferences logic to store the "installed" preference flag (`install_bundled_...`) only after a successful file copy, ensuring failed attempts can be retried on subsequent app launches.
- fix some gradle 10 syntax in builds.gradle and
gradle.properties

- use ivy repo for ant+ lib
Update code with api-13 to remove deprecated calls.
(suppress for <api-33).

Support HR transmitter that do not support battery or firmware.
This occurs for instance for Garmin watches set to send HR
over bluetooth.
…d#1390)

Replace deprecated activity result handling with the Activity Result API while preserving existing behaviour.
)

The detail tabs kept the old Holo tab indicator as a custom view inside
the new TabLayout. TabLayout pads each tab, so the Holo underlines no
longer met and the line under the tabs broke into segments, with
TabLayout's own indicator drawn on top under the selected tab. Use plain
text tabs as the start screen does, so both screens look the same.

The map tab is now found through Tab.view rather than the custom view's
parent.

The activity details screen was the last user of
WidgetUtil.createHoloTabIndicator. Remove it and its Holo tab drawables.
TabHost found its parts through fixed ids, and the code looked up the
host itself by id. After the move to TabLayout nothing uses them, and
nothing uses the TabWidget style either:

- detail.xml: drop @+id/tabhost from the plain LinearLayout, and
  @android:id/tabcontent from the tab content FrameLayout.
- start.xml: drop @+id/tabhost_start from the plain RelativeLayout, and
  start_tabcontent from the tab content FrameLayout.
- styles.xml: drop the BottomNavigationTabWidget style and the
  android:tabWidgetStyle item in MainLayoutTheme that applied it.

The names suggested a TabHost still exists, which misleads anyone
searching the layouts.
@letharion letharion closed this Oct 9, 2026
@letharion
letharion deleted the chore/tabhost-leftover-ids branch October 12, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants