Repository navigation
Conversation
TabHost found its parts through fixed ids, and the code looked up the host itself by id. After the move to TabLayout nothing uses them, and nothing uses the TabWidget style either: - detail.xml: drop @+id/tabhost from the plain LinearLayout, and @android:id/tabcontent from the tab content FrameLayout. - start.xml: drop @+id/tabhost_start from the plain RelativeLayout, and start_tabcontent from the tab content FrameLayout. - styles.xml: drop the BottomNavigationTabWidget style and the android:tabWidgetStyle item in MainLayoutTheme that applied it. The names suggested a TabHost still exists, which misleads anyone searching the layouts.
Owner
|
+1 squashing to the previous commit (I appreciate separate commits for review though) |
Author
|
You mean this would be squashed into d001387? Makes sense to me, since that's the commit that made these bits "left overs". I don't have the access, so I'll leave that to you, but let me know if I can help. |
gerhardol
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of various leftovers that are no longer in use after the removal of tabhost.