Repository navigation
Conversation
The detail tabs kept the old Holo tab indicator as a custom view inside the new TabLayout. TabLayout pads each tab, so the Holo underlines no longer met and the line under the tabs broke into segments, with TabLayout's own indicator drawn on top under the selected tab. Use plain text tabs as the start screen does, so both screens look the same. The map tab is now found through Tab.view rather than the custom view's parent.
The activity details screen was the last user of WidgetUtil.createHoloTabIndicator. Remove it and its Holo tab drawables.
Owner
|
30s review: looks good, plan to include in my pr |
gerhardol
approved these changes
Oct 7, 2026
gerhardol
merged commit Oct 7, 2026
04d9453
into
gerhardol:feature/deprecated-tabhost
1 check passed
Owner
|
merging in jonasoreland#1396 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes createHoloTabIndicator from the activity details view, and moves to the material design language.
The benefit is that the tabs now look consistent between main view and activity view, and, at least in my opinion, also looks better.
As a bonus, this appears to be the last call to createHoloTabIndicator, so we can now drop it.
Screenshot of the new view:
I crossposted to the upstream PR as well so it's easy to compare with the previous screenshots.