Repository navigation
Conversation
Notifications were left stuck after the completion of a workout. Cancel the notification id explicitly removes it.
Owner
|
For me the tab switches also for the Play version. But ifyou think it should be changed, OK. |
Author
|
Interesting. I started up the play version, 2.11.0.1, and I can't reproduce the behavior there. The play version stays on the advanced tab when I flip dark mode on/off. |
gerhardol
force-pushed
the
feature/deprecated-tabhost
branch
from
October 11, 2026 19:12
50bcfb7 to
720edde
Compare
) The detail tabs kept the old Holo tab indicator as a custom view inside the new TabLayout. TabLayout pads each tab, so the Holo underlines no longer met and the line under the tabs broke into segments, with TabLayout's own indicator drawn on top under the selected tab. Use plain text tabs as the start screen does, so both screens look the same. The map tab is now found through Tab.view rather than the custom view's parent. The activity details screen was the last user of WidgetUtil.createHoloTabIndicator. Remove it and its Holo tab drawables.
Owner
|
please reopen on jonasoreland repo, and we merge it there (I can reopen but not move). |
gerhardol
approved these changes
Oct 11, 2026
Save and restore tab positions on the start and activity details screens.
letharion
force-pushed
the
fix/tab-restore
branch
from
October 12, 2026 05:12
c599156 to
8c6554d
Compare
Author
|
@gerhardol Moved to jonasoreland#1399 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save and restore tab positions on the start and activity details screens.
The old TabHost kept track of which was the active tab, in a way that TabLayout does not.
If you pick "advanced", change the screen re-renders, for example due to switching to dark mode, then you end up back at the first tab again.
This adds tracking of the users tracked.