Skip to content

chore: sync upstream (2026-11-16) - #28

Merged
getBoolean merged 113 commits into
mainfrom
sync/upstream-2026-11-16
Nov 16, 2026
Merged

getBoolean merged 113 commits into
mainfrom
sync/upstream-2026-11-16

Conversation

@getBoolean

@getBoolean getBoolean commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Merges 110 upstream commits, pingdotgg/t3code 649d9fc1ab..629d5083b7, into the fork with a merge commit. Every fork-owned change survives.

Conflicts and resolutions

  • apps/mobile/src/features/layout/workspace/WorkspaceNativeTabs.ios.tsx: upstream now pre-warms hidden tabs (fix(mobile): first visit to an iOS tab no longer flashes black pingdotgg/t3code#37083, fix(mobile): a tab's bar buttons no longer fade in on its first visit pingdotgg/t3code#37302, fix(mobile): a tab's first visit appears whole, without a tab bar bounce pingdotgg/t3code#37530). That turned children into a (workspace, headerOnly) => ReactNode render function and added slot mount tracking and shared column metrics. Kept all of upstream's version. Re-applied the fork's sidebar-footer tab bar and iPad sidebar-navigation path after upstream's new hooks. The fork's early return now calls props.children(workspace, false). Upstream's 280pt-capped iPad overlay stays replaced by the fork's sidebar-slot footer.
  • apps/mobile/src/features/layout/createWorkspaceStackNavigator.ios.tsx: upstream now picks columns or the card stack per tab slot. Took upstream's render function and kept the fork's intent: iPad always uses split columns (deviceType === "pad" || workspaceUsesColumns(...)), and the card stack keeps workspaceDetailSlot on iPad.
  • workspace-tab-navigation.test.ts: kept the fork's sidebarNavigation assertions and added upstream's hidden-tab page-key loop.
  • ThreadNavigationSidebar.tsx: upstream renamed THREAD_SIDEBAR_ROW_LAYOUT to THREAD_LIST_ROW_LAYOUT. Kept the fork's renderNativeScrollView.
  • UsageRouteScreen.tsx: imports now include both upstream's use and the fork's Platform.
  • agentContextBudget.json: set mcpToolListJsonBytes to the measured 50513.

Fork adaptations

  • ci: run the new EAS preview build jobs on fork-configurable runners: ran the enabling-fork-ci audit with --rewrite-runners --prefix T3CODE. It rewrote the new ios-build (macOS) and comment jobs in mobile-eas-preview.yml and mobile-eas-preview-fork.yml. Both jobs are label-gated. There are no new github.repository == 'pingdotgg/t3code' guards and no new hard-coded upstream names outside provenance links. ci.yml gains no macOS job.
  • The manifest has new anchors for the reconciled iPad overrides and runner rewrites. bash scripts/check-fork-manifest.sh: 548 entries present.
  • Upstream bumped the bundled react-native-screens fork from t3.50 to t3.58. The fork doesn't patch it, and its podspec minimum stays 15.1.

Verification

  • Server fork suites (src/gitAccounts, terminal/Manager, cloud/npmRelease, PullRequestService, mcp/toolkits/project, AgentContextBudget): 316/316 passed.
  • Mobile: remoteRegistration, features/layout, workspace-stack-projection: 136/136 passed. Mobile typecheck: no errors.
  • Web: GitAccountsSettings.browser.test.tsx: 2/2 passed.
  • CI: every check green on 4726d2c102.
  • vp run check:changed: format, lint, knip, graphql, typecheck (41 packages), react compiler and unused patches all pass. Its 103-file test step was killed by the 900s timeout while running alongside the Xcode build. CI runs the full suites.

iOS 17

Passed. deploymentTarget stays 17.0.

  • Risk read: the only native dependency change is upstream's react-native-screens fork bump (t3.50 to t3.58). Its new Objective-C++ code (tab prewarm, selection cover, animatesPush) uses only long-standing UIKit APIs, and its podspec minimum stays 15.1. The new and changed Swift (T3NativeImageViewer, file presentation, scroll-edge bleed) guards iOS 26 behavior with #available/#unavailable. infra/relay and packages/contracts/src/relay.ts don't use iosMajorVersion. No JS/TS code uses iOS 18+ features.
  • Build: Release simulator build with Xcode 26.6, React Native built from source: succeeded. Deployment targets are 16.4 and 17.0 for the app and 15.1/16.4/17.0 for pods.
  • Symbols: libc++ check: 277 symbols, all exported by iOS 17.0. check_runtime_symbols.py --runtime 17.0: 10,978 imports from 7 Mach-O files, nothing missing.
  • Launch: iPhone 15 Pro and iPad Pro 12.9" (6th gen) on iOS 17.0 (21A328) both kept running past 30 seconds, with no crash report. The app was installed through simctl because agent-device's tar install still drops the sparse hermesvm binary, which dyld reports as "Library missing". That's a tool issue. On a fresh install with no environment, the iPhone shows "Loading environments", the same as the last two syncs. The UI stays responsive.
  • Native walk (native-surfaces-open, run against its own throwaway server): passed with 0 failed steps on both devices. The iPad keeps the fork's sidebar utilities and split columns through upstream's tab prewarm.
Release launch, iPhone 15 Pro (iOS 17.0) Release launch, iPad Pro 12.9" (iOS 17.0)
Walk iPhone 15 Pro iPad Pro 12.9"
Compose
Source control (git accounts)
Usage
Thread

Opus 5.5 (claude-opus-5-5) in Claude Code, run from T3 Code.

StiensWout and others added 30 commits November 15, 2026 04:04
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ker in the same session (pingdotgg#37165)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#37193)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#37179)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#37198)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gdotgg#37201)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…g#37158)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#37208)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#37141)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…nes (pingdotgg#37243)

Co-authored-by: Grok 4.7 <noreply@x.ai>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…7233)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
StiensWout and others added 23 commits November 15, 2026 23:25
…37526)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#37537)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…reported" (pingdotgg#36897)

Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
…gg#37562)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… list (pingdotgg#37554)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…nce (pingdotgg#37530)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…sidebar (pingdotgg#37557)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ema is current (pingdotgg#37564)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
… for minutes (pingdotgg#37538)

Co-authored-by: Tobias <tobias@MacStudonTobias.localdomain>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tle limits (pingdotgg#37565)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
# Conflicts:
#	apps/mobile/src/features/layout/createWorkspaceStackNavigator.ios.tsx
#	apps/mobile/src/features/layout/workspace/WorkspaceNativeTabs.ios.tsx
#	apps/mobile/src/features/layout/workspace/workspace-tab-navigation.test.ts
#	apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx
#	apps/mobile/src/features/usage/UsageRouteScreen.tsx
#	apps/server/src/provider/agentContextBudget.json
… prewarm

Records manifest anchors for the reconciled iPad overrides and sets the
measured MCP tool-list budget after the upstream merge.
@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XXL labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown

This PR changes the test suite by +87 test cases (browser +12, unit +35, server +40).

New browser test files: apps/web/src/components/usage/UsageModelDialog.browser.test.tsx.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

@github-actions github-actions Bot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Nov 16, 2026
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.5 KiB 21.5 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 1 1 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB 0 B (0.0%) 24.4 KiB ✅
Claude Live turn messages 1 1 0 (0.0%) 8 ✅

Other scenarios

All 64 scenario measurements match main.

All 64 scenario measurements
Provider Scenario Metric Main baseline This PR Impact PR ceiling
Codex short turn resume WebSocket decoded 10.5 KiB 10.5 KiB 0 B (0.0%) 12.7 KiB ✅
Codex short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn running, cold open HTTP decoded 230.3 KiB 230.3 KiB 0 B (0.0%) 302.7 KiB ✅
Codex long turn running, cold open rows 25 25 0 (0.0%) 75 ✅
Codex long turn running, history page HTTP decoded 89.3 KiB 89.3 KiB 0 B (0.0%) 107.4 KiB ✅
Codex long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Codex long turn finished, cold open HTTP decoded 68.3 KiB 68.3 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, cold open rows 21 21 0 (0.0%) 151 ✅
Codex long turn finished, socket cold open WebSocket decoded 68.4 KiB 68.4 KiB 0 B (0.0%) 410.2 KiB ✅
Codex long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex long turn finished, socket cold open rows 21 21 0 (0.0%) 151 ✅
Codex long turn finished, work page HTTP decoded 94.4 KiB 94.4 KiB 0 B (0.0%) 200.2 KiB ✅
Codex long turn finished, work page rows 75 75 0 (0.0%) 150 ✅
Codex idle thread resume WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell snapshot HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Codex fleet shell subscribe WebSocket decoded 65 B 65 B 0 B (0.0%) 200 B ✅
Codex fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Codex fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Codex fleet shell resume check rows 0 0 0 0 ✅
Codex stale shell reload HTTP decoded 42.4 KiB 42.4 KiB 0 B (0.0%) 53.7 KiB ✅
Codex stale shell reload rows 27 27 0 (0.0%) 27 ✅
Codex stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Codex stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Codex stale todo list cold open HTTP decoded 36.4 KiB 36.4 KiB 0 B (0.0%) 83.0 KiB ✅
Codex stale todo list cold open rows 25 25 0 (0.0%) 75 ✅
Codex stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Codex stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Codex stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅
Claude short turn resume WebSocket decoded 10.6 KiB 10.6 KiB 0 B (0.0%) 12.7 KiB ✅
Claude short turn resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn running, cold open HTTP decoded 231.3 KiB 231.3 KiB 0 B (0.0%) 302.7 KiB ✅
Claude long turn running, cold open rows 25 25 0 (0.0%) 75 ✅
Claude long turn running, history page HTTP decoded 90.2 KiB 90.2 KiB 0 B (0.0%) 107.4 KiB ✅
Claude long turn running, history page rows 75 75 0 (0.0%) 75 ✅
Claude long turn finished, cold open HTTP decoded 68.7 KiB 68.7 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, cold open rows 21 21 0 (0.0%) 151 ✅
Claude long turn finished, socket cold open WebSocket decoded 68.8 KiB 68.8 KiB 0 B (0.0%) 410.2 KiB ✅
Claude long turn finished, socket cold open WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude long turn finished, socket cold open rows 21 21 0 (0.0%) 151 ✅
Claude long turn finished, work page HTTP decoded 95.4 KiB 95.4 KiB 0 B (0.0%) 200.2 KiB ✅
Claude long turn finished, work page rows 75 75 0 (0.0%) 150 ✅
Claude idle thread resume WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude idle thread resume WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell snapshot HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude fleet shell snapshot rows 27 27 0 (0.0%) 27 ✅
Claude fleet shell subscribe WebSocket decoded 66 B 66 B 0 B (0.0%) 200 B ✅
Claude fleet shell subscribe WebSocket messages 1 1 0 (0.0%) 1 ✅
Claude fleet shell resume check HTTP decoded 18 B 18 B 0 B (0.0%) 100 B ✅
Claude fleet shell resume check rows 0 0 0 0 ✅
Claude stale shell reload HTTP decoded 43.0 KiB 43.0 KiB 0 B (0.0%) 53.7 KiB ✅
Claude stale shell reload rows 27 27 0 (0.0%) 27 ✅
Claude stale shell resume WebSocket decoded 140 B 140 B 0 B (0.0%) 400 B ✅
Claude stale shell resume WebSocket messages 2 2 0 (0.0%) 2 ✅
Claude stale todo list cold open HTTP decoded 36.8 KiB 36.8 KiB 0 B (0.0%) 83.0 KiB ✅
Claude stale todo list cold open rows 25 25 0 (0.0%) 75 ✅
Claude stale todo list cold open nodes 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open subagents 2 2 0 (0.0%) 4 ✅
Claude stale todo list cold open plans 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open providerTurns 1 1 0 (0.0%) 2 ✅
Claude stale todo list cold open checkpoints 1 1 0 (0.0%) 2 ✅

Baseline: 1b044d6 · PR result: 4726d2c · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@getBoolean
getBoolean merged commit c82ee34 into main Nov 16, 2026
38 checks passed
@getBoolean
getBoolean deleted the sync/upstream-2026-11-16 branch November 16, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.