Repository navigation
fix: record positional optional params and **kwargs correctly - #389
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Python argument-recording changes.
No open issues 🎉
What changed in this PR
This PR corrects how AppMap records Python function arguments, aligning recorded parameter values with Python’s argument binding behavior.
Changes:
- Record optional parameters passed positionally without incorrectly including them in
*args. - Exclude named keyword parameters from recorded
**kwargs, while preserving keywords that match positional-only parameter names. - Add regression tests for mixed parameter kinds, defaults, and positional-only name collisions.
| File | Description |
|---|---|
_appmap/test/test_params.py |
Adds regression tests for positional defaults and keyword argument binding. |
_appmap/test/data/params.py |
Adds mixed-parameter and positional-only test fixtures. |
_appmap/event.py |
Tracks positional-only parameters and corrects parameter value selection and **kwargs filtering. |
Review effort: Balanced
Parameters with a default were only looked up in kwargs, so when passed
positionally they were recorded as their default value, and the
positional values spilled over into *args instead. E.g. for
f(self, a, b=None) called as f('A', 'B'), b was recorded as None.
**kwargs was recorded as the full keyword argument dict, including
arguments bound to named parameters. It now only contains the ones
Python would actually put there. In particular, keyword arguments
named like positional-only parameters now go to **kwargs rather than
being recorded as the value of the positional-only parameter.
Assisted-by: Claude:claude-opus-5-5
dividedmind
force-pushed
the
fix/positional-optional-params
branch
from
November 10, 2026 17:24
a4952a6 to
4082a7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameters with a default were only looked up in kwargs, so when passed positionally they were recorded as their default value, and the positional values spilled over into *args instead. E.g. for f(self, a, b=None) called as f('A', 'B'), b was recorded as None.
**kwargs was recorded as the full keyword argument dict, including arguments bound to named parameters. It now only contains the ones Python would actually put there. In particular, keyword arguments named like positional-only parameters now go to **kwargs rather than being recorded as the value of the positional-only parameter.
Assisted-by: Claude:claude-opus-5-5