Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions _appmap/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,11 @@ class DistMatcher(PathMatcher):
def __init__(self, dist, *args, **kwargs):
super().__init__(*args, **kwargs)
self.dist = dist
dist_files = importlib.metadata.files(dist)
self.files = [str(pp.locate()) for pp in dist_files] if dist_files is not None else []
try:
dist_files = importlib.metadata.files(dist)
self.files = [str(pp.locate()) for pp in dist_files] if dist_files is not None else []
except importlib.metadata.PackageNotFoundError:
self.files = []

def matches(self, filterable):
try:
Expand Down
27 changes: 26 additions & 1 deletion _appmap/test/test_configuration.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Test Configuration"""
# pylint: disable=missing-function-docstring

import importlib.metadata
from contextlib import contextmanager
from shutil import copytree
from pathlib import Path
Expand All @@ -11,7 +12,14 @@

import _appmap
import appmap
from _appmap.configuration import Config, ConfigFilter

from _appmap.configuration import (
Config,
ConfigFilter,
DistMatcher,
PathMatcher,
matcher_of_config,
)
from _appmap.env import Env
from _appmap.importer import Filterable, NullFilter

Expand Down Expand Up @@ -340,3 +348,20 @@ def test_config_not_found_in_path_hierarchy(self, data_dir, tmpdir, monkeypatch)
Config.current # pylint: disable=pointless-statement
# No default config since we specified APPMAP_CONFIG
assert not Env.current.enabled


def test_missing_distribution_does_not_stop_other_packages(mocker):
mocker.patch(
"importlib.metadata.files",
side_effect=importlib.metadata.PackageNotFoundError("missing-package"),
)

matchers = [
matcher_of_config({"dist": "missing-package", "path": "missing_package"}),
matcher_of_config({"path": "other_package"}),
]

assert len(matchers) == 2
assert isinstance(matchers[0], DistMatcher)
assert matchers[0].files == []
assert isinstance(matchers[1], PathMatcher)